Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(HTTP Request Node): Show error cause in the output #4538

Merged
merged 1 commit into from
Nov 7, 2022
Merged

fix(HTTP Request Node): Show error cause in the output #4538

merged 1 commit into from
Nov 7, 2022

Conversation

netroy
Copy link
Member

@netroy netroy commented Nov 7, 2022

@netroy netroy requested a review from RicardoE105 November 7, 2022 16:22
@linear
Copy link

linear bot commented Nov 7, 2022

N8N-5413

@netroy netroy changed the title fix (HTTP Request node): show error cause in the output fix (HTTP Request node): Show error cause in the output Nov 7, 2022
@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team labels Nov 7, 2022
@ivov ivov changed the title fix (HTTP Request node): Show error cause in the output fix(HTTP Request node): Show error cause in the output Nov 7, 2022
@ivov ivov changed the title fix(HTTP Request node): Show error cause in the output fix(HTTP Request Node): Show error cause in the output Nov 7, 2022
RicardoE105
RicardoE105 approved these changes Nov 7, 2022
View reviewed changes
Copy link
Contributor

@RicardoE105 RicardoE105 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested with the same service the user who reported it used and it works as expected.

@RicardoE105 RicardoE105 merged commit c239eea into master Nov 7, 2022
@RicardoE105 RicardoE105 deleted the N8N-5413-fix-NodeError-cause branch November 7, 2022 17:40
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 7, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 8, 2022
@MiloradFilipovic
Merge branch 'master' into N8N-5191-pinia-migration-part2
568efbf 
* master:
  fix(editor): Fix for incorrect execution saving indicator in executions view (#4547)
  feat(API): Report unhandled app crashes to Sentry (#4548)
  fix(SendInBlue Trigger Node): fix typo in credential name (#4357)
  refactor(core): Update rule typescript-eslint/no-unused-vars to not error when variable starts with _ (#4523)
  refactor: make IPollFunctions emit consistent with trigger emit (#4201)
  feat: Add cypress e2e tests for signup and signin (#3490)
  fix(core): Fix manual execution of pinned trigger on main mode (#4535)
  fix(HTTP Request Node): Show error cause in the output (#4538)
  refactor(core): Skip interim updates check (no-changelog) (#4536)
  ci: Revert support for node.js 18 (#4518) (#4537)
  ci: Start supporting node.js 18 (#4518)
@janober
Copy link
Member

janober commented Nov 10, 2022

Got released with n8n@0.202.0

@janober janober removed the Upcoming Release Will be part of the upcoming release label Nov 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RicardoE105 RicardoE105 RicardoE105 approved these changes

Assignees
No one assigned
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@netroy @janober @RicardoE105