Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(core): Introduce overload for number-type node parameter (no-changelog) #4644

Merged
merged 6 commits into from
Nov 18, 2022

Conversation

ivov
Copy link
Contributor

@ivov ivov commented Nov 18, 2022

No description provided.

@netroy
Copy link
Member

netroy commented Nov 18, 2022

looks great. but, prettier changes make it a bit difficult to read what all changed.

@n8n-assistant n8n-assistant bot added core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request labels Nov 18, 2022
@ivov
Copy link
Contributor Author

ivov commented Nov 18, 2022

My bad! Will prevent next time.

For reference, these had a Prettier pass:

  • packages/nodes-base/nodes/Asana/Asana.node.ts
  • packages/nodes-base/nodes/Aws/CertificateManager/AwsCertificateManager.node.ts
  • packages/nodes-base/nodes/Dropbox/Dropbox.node.ts
  • packages/nodes-base/nodes/Google/Gmail/v1/GmailV1.node.ts
  • packages/nodes-base/nodes/Mautic/Mautic.node.ts
  • packages/nodes-base/nodes/NocoDB/NocoDB.node.ts
  • packages/nodes-base/nodes/Notion/v1/NotionV1.node.ts
  • packages/nodes-base/nodes/Notion/v2/NotionV2.node.ts
  • packages/nodes-base/nodes/Pipedrive/Pipedrive.node.ts
  • packages/nodes-base/nodes/S3/S3.node.ts
  • packages/nodes-base/nodes/SendGrid/SendGrid.node.ts
  • packages/nodes-base/nodes/Spotify/Spotify.node.ts
  • packages/nodes-base/nodes/Venafi/Datacenter/VenafiTlsProtectDatacenter.node.ts
  • packages/nodes-base/nodes/Venafi/ProtectCloud/VenafiTlsProtectCloud.node.ts

@ivov ivov added the tech debt label Nov 18, 2022
@netroy
Copy link
Member

netroy commented Nov 18, 2022

LGTM, but there are conflicts now.

@netroy netroy merged commit 0565194 into master Nov 18, 2022
@netroy netroy deleted the n8n-5269-overload-number-type branch November 18, 2022 14:26
@n8n-assistant n8n-assistant bot added the Upcoming Release Will be part of the upcoming release label Nov 18, 2022
@netroy netroy changed the title refactor(core): Introduce overload for number-type node parameter (no-changelog) refactor(core): Introduce overload for number-type node parameter (no-changelog) N8N-5629 Nov 18, 2022
@netroy netroy changed the title refactor(core): Introduce overload for number-type node parameter (no-changelog) N8N-5629 refactor(core): Introduce overload for number-type node parameter (no-changelog) Nov 18, 2022
@janober janober added Upcoming Release Will be part of the upcoming release and removed Upcoming Release Will be part of the upcoming release labels Nov 18, 2022
MiloradFilipovic added a commit that referenced this pull request Nov 18, 2022
* master:
  fix(editor): Fix missing resource locator component (#4649)
  refactor(core): Introduce overload for record-type node parameter (no-changelog) (#4648)
  refactor(core): Introduce overload for number-type node parameter (no-changelog) (#4644)
  refactor: Migrate Vue slots to the new syntax (#4603)
  refactor(core): Introduce overload for boolean-type node parameter (no-changelog) (#4647)
  fix: Make users fakedoor route visible on cloud (#4645)
  📚 Update CHANGELOG.md and main package.json to 0.203.1
MiloradFilipovic added a commit that referenced this pull request Nov 21, 2022
* feature/ad-ldap: (108 commits)
  👕 Fix linting problem
  fix: Workflow activation should not crash if one of the credential is invalid (#4671)
  feat(core): Add license support to n8n (#4566)
  fix: Use the updated slots syntax in ResourceLocator (no-changelog) (#4663)
  fix: Community package uninstall button should show the confirmation modal (no-changelog) (#4668)
  fix: Fix broken n8n-info-tip slots (#4665)
  fix(editor): Table view column limit tooltip (#4655)
  ci: Block execution of `npm install` (no-changelog) (#4662)
  fix(editor): Prevent node-creator tabs from showing when toggled by CanvasAddButton (#4661)
  fix(Schedule Trigger Node): Fixes inconsitent behavior with cron and weekly intervals (#4558)
  fix(core): Fix for unused imports
  fix: Add temporary slot syntax lint exceptions (no-changelog) (#4652)
  fix(editor): Fix missing resource locator component (#4649)
  refactor(core): Introduce overload for record-type node parameter (no-changelog) (#4648)
  refactor(core): Introduce overload for number-type node parameter (no-changelog) (#4644)
  refactor: Migrate Vue slots to the new syntax (#4603)
  refactor(core): Introduce overload for boolean-type node parameter (no-changelog) (#4647)
  fix: Make users fakedoor route visible on cloud (#4645)
  📚 Update CHANGELOG.md and main package.json to 0.203.1
  🔖 Release n8n@0.203.1
  ...

# Conflicts:
#	packages/design-system/src/components/N8nFormInput/FormInput.vue
#	packages/design-system/src/components/N8nFormInputs/FormInputs.stories.js
#	packages/design-system/src/components/N8nFormInputs/FormInputs.vue
#	packages/design-system/src/types/form.ts
@janober
Copy link
Member

janober commented Nov 24, 2022

Got released with n8n@0.204.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Enhancement outside /nodes-base and /editor-ui n8n team Authored by the n8n team node/improvement New feature or request tech debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants