fix: Stop using prefixed core modules from nodejs (no-changelog) #4813
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Starting node 18, there are some core modules that only work with the `node:` prefix, like `node:test`. It's very likely that nodejs will switch to prefix-only core modules in the next versions as un-prefixed core modules are susceptible to supply-chain attacks.
netroy
changed the title
mutdmour
approved these changes
Dec 5, 2022
n8n-assistant
bot
added
core
MiloradFilipovic
added a commit
that referenced
this pull request
Dec 5, 2022
* master: fix: Stop using prefixed core modules from nodejs (no-changelog) (#4813) fix: Refresh credentials when re-entering workflows page (no-changelog) (#4815) ci: Update slack notification messages for e2e tests (no-changelog) (#4812) refactor(Code Node): Limit n8n item key check (#4737) docs: Update README (no-changelog) (#4636) fix(core): Fix partial execution with pinned data on child node run (#4764) fix(Execute Workflow Node): Update Execute Workflow node info notice text (#4809)
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting node 18, there are some core modules that only work with the
node:prefix, likenode:test. It's very likely that nodejs will switch to prefix-only core modules in the next versions as un-prefixed core modules are susceptible to supply-chain attacks.So, after we drop node 14, we should update all core modules to use the prefix.