Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Update Notion nodes to remove beta from name #4838

Merged
merged 2 commits into from
Jan 20, 2023
Merged

refactor: Update Notion nodes to remove beta from name #4838

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e617a7f
update notion node to remove beta wording
Joffcom Dec 6, 2022
5d27cd5
updated wording on Notion trigger
Joffcom Dec 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions packages/nodes-base/nodes/Notion/DatabaseDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,19 +141,6 @@ export const databaseFields: INodeProperties[] = [
/* -------------------------------------------------------------------------- */
/* database:getAll */
/* -------------------------------------------------------------------------- */
{
displayName:
'In Notion, make sure you <a href="https://www.notion.so/help/add-and-manage-connections-with-the-api#add-connections-to-pages" target="_blank">share your database with your integration</a> . Otherwise it won\'t be accessible, or listed here.',
name: 'notionNotice',
type: 'notice',
default: '',
displayOptions: {
show: {
resource: ['database'],
operation: ['getAll'],
},
},
},
{
displayName: 'Return All',
name: 'returnAll',
Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/Notion/Notion.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,12 @@ import { NotionV2 } from './v2/NotionV2.node';
export class Notion extends VersionedNodeType {
constructor() {
const baseDescription: INodeTypeBaseDescription = {
displayName: 'Notion (Beta)',
displayName: 'Notion',
name: 'notion',
icon: 'file:notion.svg',
group: ['output'],
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
description: 'Consume Notion API (Beta)',
description: 'Consume Notion API',
defaultVersion: 2,
};

Expand Down
4 changes: 2 additions & 2 deletions packages/nodes-base/nodes/Notion/NotionTrigger.node.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ import { getDatabases } from './SearchFunctions';
export class NotionTrigger implements INodeType {
description: INodeTypeDescription = {
// eslint-disable-next-line n8n-nodes-base/node-class-description-display-name-unsuffixed-trigger-node
displayName: 'Notion Trigger (Beta)',
displayName: 'Notion Trigger',
name: 'notionTrigger',
icon: 'file:notion.svg',
group: ['trigger'],
Expand Down Expand Up @@ -49,7 +49,7 @@ export class NotionTrigger implements INodeType {
},
{
displayName:
'In Notion, make sure you <a href="https://www.notion.so/help/add-and-manage-connections-with-the-api#add-connections-to-pages" target="_blank">share your database with your integration</a> . Otherwise it won\'t be accessible, or listed here.',
'In Notion, make sure to <a href="https://www.notion.so/help/add-and-manage-connections-with-the-api" target="_blank">add your connection</a> to the pages you want to access.',
name: 'notionNotice',
type: 'notice',
default: '',
Expand Down
7 changes: 4 additions & 3 deletions packages/nodes-base/nodes/Notion/v1/VersionDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ import { databasePageFields, databasePageOperations } from '../DatabasePageDescr
import { INodeTypeDescription } from 'n8n-workflow';

export const versionDescription: INodeTypeDescription = {
displayName: 'Notion (Beta)',
displayName: 'Notion',
name: 'notion',
icon: 'file:notion.svg',
group: ['output'],
version: 1,
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
description: 'Consume Notion API (Beta)',
description: 'Consume Notion API',
defaults: {
name: 'Notion',
},
Expand Down Expand Up @@ -67,7 +67,8 @@ export const versionDescription: INodeTypeDescription = {
// description: 'The resource to operate on.',
// },
{
displayName: "To access content, make sure it's shared with your integration in Notion",
displayName:
'In Notion, make sure to <a href="https://www.notion.so/help/add-and-manage-connections-with-the-api" target="_blank">add your connection</a> to the pages you want to access.',
name: 'notionNotice',
type: 'notice',
default: '',
Expand Down
7 changes: 4 additions & 3 deletions packages/nodes-base/nodes/Notion/v2/VersionDescription.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,13 +12,13 @@ import { databasePageFields, databasePageOperations } from '../DatabasePageDescr
import { INodeTypeDescription } from 'n8n-workflow';

export const versionDescription: INodeTypeDescription = {
displayName: 'Notion (Beta)',
displayName: 'Notion',
name: 'notion',
icon: 'file:notion.svg',
group: ['output'],
version: 2,
subtitle: '={{$parameter["operation"] + ": " + $parameter["resource"]}}',
description: 'Consume Notion API (Beta)',
description: 'Consume Notion API',
defaults: {
name: 'Notion',
},
Expand Down Expand Up @@ -67,7 +67,8 @@ export const versionDescription: INodeTypeDescription = {
// description: 'The resource to operate on.',
// },
{
displayName: "To access content, make sure it's shared with your integration in Notion",
displayName:
'In Notion, make sure to <a href="https://www.notion.so/help/add-and-manage-connections-with-the-api" target="_blank">add your connection</a> to the pages you want to access.',
name: 'notionNotice',
type: 'notice',
default: '',
Expand Down