-
Notifications
You must be signed in to change notification settings - Fork 10.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add global event bus #4860
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # package-lock.json # packages/cli/package.json # packages/cli/src/Interfaces.ts # packages/cli/src/Server.ts
netroy
requested changes
Jan 3, 2023
packages/cli/src/eventbus/MessageEventBusDestination/MessageEventBusDestinationWebhook.ee.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/eventbus/MessageEventBusDestination/MessageEventBusDestination.ee.ts
Outdated
Show resolved
Hide resolved
netroy
reviewed
Jan 3, 2023
netroy
previously approved these changes
Jan 3, 2023
netroy
previously approved these changes
Jan 3, 2023
because there is a folder called `events`, tsc-alias is messing up all imports for native events module. justkey007/tsc-alias#152
netroy
force-pushed
the
n8n-5359-mvp-event-bus
branch
from
January 4, 2023 00:06
5925ffd
to
a9c99f8
Compare
netroy
approved these changes
Jan 4, 2023
krynble
approved these changes
Jan 4, 2023
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.