fix(editor): Correctly display trigger nodes without actions and with related regular node in the "On App Events" category #4976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lar node wouldn't show in the "On App Events" category
netroy
reviewed
Dec 19, 2022
mutdmour
approved these changes
Dec 19, 2022
netroy
approved these changes
Dec 19, 2022
netroy
deleted the
merged-trigger-nodes-without-actions-not-displaying
branch
n8n-assistant
bot
added
the
Upcoming Release
|
Got released with |
netroy
pushed a commit
that referenced
this pull request
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the "On App Events" category we merge trigger and regular nodes. We then filter-out regular nodes without actions. But if in the merging function, the regular node would appear first we'd use it as the merge baseline. So if it has a trigger counterpart without actions, it would get filtered out. To solve this, we simply sort the nodes before merging, to make sure trigger nodes are always on top.
The affected nodes were:
Closes #4952