-
Notifications
You must be signed in to change notification settings - Fork 11.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Use string ids on Credentials, Workflows, Tags, and Executions DB entities #5041
Conversation
instead of transforming between string and number throughout the code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More IDs to update:
IWorkflowMetadata
at/workflow/src/Interfaces.ts
IExecutionBase
atpackages/editor-ui/src/Interface.ts
(Unless they had to be excluded for some reason.)
Only code review, untested.
packages/cli/src/PublicApi/v1/handlers/credentials/credentials.handler.ts
Outdated
Show resolved
Hide resolved
packages/cli/src/PublicApi/v1/handlers/credentials/credentials.service.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job :)
A few more I found:
IExecutionBase['retrySuccessId']
in cli is stillstring | number
butstring
in editor-uicredentialId
inCredentialConfig.vue
is still[String, Number]
Otherwise code looks good, I'll test tomorrow.
|
These both exist on master, and were likely introduced in #5035.
✅
This represents data coming from api.n8n.io. If we want to change this, we should probably also change it in the website code.
I looked at those. Those are all migrations, and should not be changed, as they do not use entity transformers.
✅
Will ask Omar 👍🏽 |
Public API schemas changed, should we update version? |
Got released with |
This was incorrectly changed in #5041
This was incorrectly changed in #5041
Ticket: N8N-3097
DB Tests: https://github.com/n8n-io/n8n/actions/runs/3799877638
E2E Tests: https://github.com/n8n-io/n8n/actions/runs/3799879311