refactor: Upgrade typeorm to 0.3.x #5151
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
force-pushed
the
N8N-3904-upgrade-typeorm
branch
from
37c123f to
e38b2d3
Compare
n8n-assistant
bot
added
core
krynble
previously approved these changes
Jan 13, 2023
There was a problem hiding this comment.
LGTM.
Tested Tags, workflows, user creation and update, running workflows, permissions, queue mode execution (trigger), webhooks, it all seems to be working fine.
What worries me is that now the find-type operation can return null instead of undefined and this could lead to potential issues. I saw that you've covered tons of places, so if there is still something it's probably minimal.
Nice job, thanks for updating this!
krynble
approved these changes
Jan 13, 2023
n8n-assistant
bot
added
the
Upcoming Release
MiloradFilipovic
added a commit
that referenced
this pull request
Jan 16, 2023
* master: (38 commits) 📚 Add warning about latest version fix: Upgrade `jsonwebtoken` to address CVE-2022-23540 (#5116) refactor: Upgrade typeorm to 0.3.x (#5151) refactor(core): Remove linting exceptions in nodes-base (no-changelog) (#4944) 📚 Update CHANGELOG.md and main package.json to 0.211.0 🔖 Release n8n@0.211.0 ⬆️ Set n8n-core@0.151.0, n8n-editor-ui@0.177.0, n8n-nodes-base@0.209.0 and n8n-workflow@0.133.0 on n8n 🔖 Release n8n-editor-ui@0.177.0 ⬆️ Set n8n-design-system@0.51.0 and n8n-workflow@0.133.0 on n8n-editor-ui 🔖 Release n8n-design-system@0.51.0 🔖 Release n8n-nodes-base@0.209.0 ⬆️ Set n8n-core@0.151.0 and n8n-workflow@0.133.0 on n8n-nodes-base 🔖 Release n8n-node-dev@0.90.0 ⬆️ Set n8n-core@0.151.0 and n8n-workflow@0.133.0 on n8n-node-dev 🔖 Release n8n-core@0.151.0 ⬆️ Set n8n-workflow@0.133.0 on n8n-core 🔖 Release n8n-workflow@0.133.0 fix(PayPal Trigger Node): Omit verification on sandbox env (#5150) fix(core): Throw error in UI on expression referencing missing node but do not fail execution (#5158) fix(Zoom Node): Add notice about deprecation of Zoom JWT app support (#5156) ... # Conflicts: # packages/editor-ui/src/constants.ts
|
Got released with |
netroy
added a commit
that referenced
this pull request
Nov 21, 2023
When we upgrade typeorm in #5151, we switched from no pooling to a default pool-size of 10. This somehow significantly deteriorates the performance of queries when the application is under load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: N8N-3904
DB tests: https://github.com/n8n-io/n8n/actions/runs/3909949464
E2E tests: https://github.com/n8n-io/n8n/actions/runs/3909952116