feat(HTTP Request Node): Move from Binary Buffer to Binary streaming #5610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
agobrech
changed the title
agobrech
changed the title
netroy
reviewed
Mar 6, 2023
…streaming-for-the-http-node
…streaming-for-the-http-node
netroy
previously requested changes
Mar 9, 2023
netroy
reviewed
Mar 9, 2023
…streaming-for-the-http-node
maspio
reviewed
Mar 9, 2023
|
Great PR! Please pay attention to the following items before merging: Files matching
Files matching
Files matching
Make sure to check off this list before asking for review. |
maspio
approved these changes
Mar 9, 2023
MiloradFilipovic
added a commit
that referenced
this pull request
Mar 10, 2023
* master: (358 commits) refactor: Remove n8n-core dependency in nodes-base (no-changelog) (#5649) 🚀 Release 0.219.0 (#5659) fix(core): Fix trying to pipe a non stream on errors (no-changelog) (#5660) ci: Fix e2e tests (no-changelog) (#5658) fix(core): Fix issues with LDAP reset and LDAP init (no-changelog) (#5657) feat(HTTP Request Node): Move from Binary Buffer to Binary streaming (#5610) feat(editor): Only redirect new users to blank canvas (no-changelog) (#5654) feat(editor): Do not automatically add manual trigger on node plus (#5644) feat(core): Allow using middlewares with decorators on a per-route basis (no-changelog) (#5656) refactor(core): Convert more routes to use the decorator pattern (no-changelog) (#5611) fix: Fetch credentials on workflows view to include in duplicated workflows (#5532) ci: Add PR checklist (#5628) feat(Mindee Node): Add support for v4 API (#5559) feat(Microsoft SQL Node): Add support for self signed certificates (#5160) fix(editor): Only fetch new versions at app launch (#5647) fix(core): Use new version of riot-tmpl in workflow package (no-changelog) (#5619) feat(core): Refactor and add SAML preferences for service provider instance (#5637) docs(Github Trigger Node): Add notice and more meaningful error around permissions (#5551) feat(Cal Trigger Node): Update to support v2 webhooks (#5331) feat(editor): Redirect users to canvas if they don't have any workflows (#5629) ...
|
Got released with |
sunilrr
pushed a commit
to fl-g6/qp-n8n
that referenced
this pull request
Apr 24, 2023
…8n-io#5610) * ✨ Change from binary buffer to binary streaming * Remove console.logs * Import Readable from the correct lib * stream response * parametersToKeyValue doesn't need to be async anymore * Fix bodyParameter reduce method * parametersToKeyValue doesn't need to be async anymore * handle streaming responses * send `Content-Length` and `Content-Type` on binary requests * Add new helper function for binary data * Add binary function to helpers interface * Fix bug in error handler * Fix issue with wrongfully assigned headers to body * Fix test workflow * Remove console.logs * Remove unnecsessary type * Remove concat dependency already imported in workflow package * Update pnpm-lock file * Small fixes, asyncronous error message * reset the lockfile * Remove buffer check and simplify error handling --------- Co-authored-by: कारतोफ्फेलस्क्रिप्ट™ <aditya@netroy.in>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.