refactor: Stop reporting to Sentry Facebook multi-webhook error (no-changelog) #7743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
netroy
approved these changes
Nov 17, 2023
| @@ -195,6 +195,7 @@ export class FacebookTrigger implements INodeType { | |||
| throw new NodeOperationError( | |||
There was a problem hiding this comment.
I'm wondering if we should create a NodeOperationWarning (and maybe NodeApiWarning), as people could forget to add severity, even when they know the severity.
There was a problem hiding this comment.
I was also thinking of a more general solution because this is neverending :)
Maybe we could have a separate nodes project in Sentry, and flip it so we only report errors there intentionally, e.g. ReportableNodeOperationError and ReportableNodeApiError - this is assuming the majority of errors in nodes-base are likely to be non-reportable because they come from external APIs, but I could be wrong to assume this.
Something to discuss with nodes team.
n8n-assistant
bot
added
n8n team
4 flaky tests on run #2935 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Code node > Code editor > should execute the placeholder successfully in both modes |
Screenshots
Video
|
|
| ... > generate code button should have correct state & tooltips |
Screenshots
Video
|
|
28-resource-mapper.cy.ts • 2 flaky tests
| Test | Artifacts | |
|---|---|---|
| Resource Mapper > should correctly delete single field |
Screenshots
Video
|
|
| Resource Mapper > should correctly delete all fields |
Screenshots
Video
|
|
Review all test suite changes for PR #7743 ↗︎
|
✅ All Cypress E2E specs passed |
MiloradFilipovic
added a commit
that referenced
this pull request
Nov 20, 2023
* master: (27 commits) fix: Include cypress TypeScript types in /cypress folder (no-changelog) (#7746) refactor(core): Stop reporting to Sentry `NodeApiError` outside 500 range (no-changelog) (#7753) fix(core): Guard against node not found on cancelling test webhook (#7750) fix(JotForm Trigger Node): Fix iteration on form loader (#7751) refactor(core): Stop reporting to Sentry unknown cred on mapping (no-changelog) (#7752) feat(core): Coordinate manual workflow activation and deactivation in multi-main scenario (#7643) ci: Fix "Release: Create Pull Request" workflow fix(editor): Fix Admin panel icon in the sidebar for cloud deployments (no-changelog) (#7738) fix(editor): Remove `n8nHooksNext` flag (no-changelog) (#7733) fix(editor): Show v1 banner dismiss button if owner (#7722) fix(GitHub Node): Fix issue preventing file edits on branches (#7734) fix(core): Fix all dependency versions for backend packages (no-changelog) (#7745) refactor(core): Convert dynamic node-parameter routes to a decorated controller (no-changelog) (#7284) refactor: Stop reporting to Sentry Facebook multi-webhook error (no-changelog) (#7743) refactor(core): Stop reporting to Sentry unrecognized node errors (no-changelog) (#7728) fix(core): Account for non-ASCII chars in filename on binary data download (#7742) ci: Fix DB tests and Workflow tests (no-changelog) (#7741) refactor: Extract Invitation routes to InvitationController (no-changelog) (#7726) fix(editor): Handle permission edge cases (empty scopes) (#7723) ci: Skip the regularly failing tests in 2-credentials.cy.ts (no-changelog) (#7736) ...
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://n8nio.sentry.io/issues/4640072705