Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(FTP Node): Continue of fail looping support with paired item #8659

Conversation

michael-radency
Copy link
Contributor

Summary

FTP Node - Continue on Fail doesn't output paired items

Related tickets and issues

https://linear.app/n8n/issue/NODE-1126/ftp-node-continue-on-fail-doesnt-output-paired-items

@michael-radency michael-radency added n8n team Authored by the n8n team node/issue Issue with a node labels Feb 16, 2024
Copy link

cypress bot commented Feb 19, 2024

2 flaky tests on run #4146 ↗︎

0 339 12 0 Flakiness 2

Details:

🌳 master 🖥️ browsers:node18.12.0-chrome107 🤖 PR User 🗃️ e2e/*
Project: n8n Commit: 3279762221
Status: Passed Duration: 03:34 💡
Started: Feb 20, 2024 3:10 AM Ended: Feb 20, 2024 3:14 AM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  12-canvas-actions.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Canvas Actions > Node hover actions > should execute node Test Replay Screenshots Video

Review all test suite changes for PR #8659 ↗︎

Copy link
Contributor

✅ All Cypress E2E specs passed

@michael-radency michael-radency merged commit 3279762 into master Feb 19, 2024
28 checks passed
@michael-radency michael-radency deleted the node-1126-ftp-node-continue-on-fail-doesnt-output-paired-items branch February 19, 2024 16:21
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
@janober
Copy link
Member

janober commented Feb 21, 2024

Got released with n8n@1.30.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team node/issue Issue with a node Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants