Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(AI Agent Node): Whitelist Azure Chat model for Agent #8699

Merged
merged 2 commits into from
Feb 21, 2024

Conversation

OlegIvaniv
Copy link
Contributor

Summary

Whitelist Azure Chat model so it's usable with AI Agent node

Related tickets and issues

Include links to Linear ticket or Github issue or Community forum post. Important in order to close automatically and provide context to reviewers.

Review / Merge checklist

  • PR title and summary are descriptive. Remember, the title automatically goes into the changelog. Use (no-changelog) otherwise. (conventions)
  • Docs updated or follow-up ticket created.
  • Tests included.

    A bug is not considered fixed, unless a test is added to prevent it from happening again.
    A feature is not complete without tests.

Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
@OlegIvaniv OlegIvaniv changed the title feat(AI Agent): Whitelist Azure Chat model for Agent feat(AI Agent Node): Whitelist Azure Chat model for Agent Feb 21, 2024
@n8n-assistant n8n-assistant bot added the n8n team Authored by the n8n team label Feb 21, 2024
Copy link

cypress bot commented Feb 21, 2024

2 flaky tests on run #4172 ↗︎

0 338 12 0 Flakiness 2

Details:

🌳 🖥️ browsers:node18.12.0-chrome107 🤖 OlegIvaniv 🗃️ e2e/*
Project: n8n Commit: e313d1a222
Status: Passed Duration: 03:41 💡
Started: Feb 21, 2024 1:17 PM Ended: Feb 21, 2024 1:21 PM
Flakiness  5-ndv.cy.ts • 1 flaky test

View Output Video

Test Artifacts
NDV > should not retrieve remote options when required params throw errors Test Replay Screenshots Video
Flakiness  30-editor-after-route-changes.cy.ts • 1 flaky test

View Output Video

Test Artifacts
Editor zoom should work after route changes > after switching between Editor and Workflow history and Workflow list Test Replay Screenshots Video

Review all test suite changes for PR #8699 ↗︎

Copy link
Contributor

⚠️ Some Cypress E2E specs are failing, please fix them before merging

Copy link
Contributor

✅ All Cypress E2E specs passed

@OlegIvaniv OlegIvaniv merged commit 40aecd1 into master Feb 21, 2024
28 checks passed
@OlegIvaniv OlegIvaniv deleted the ai_enable_azure_chat_agent branch February 21, 2024 13:57
@github-actions github-actions bot mentioned this pull request Feb 21, 2024
@janober
Copy link
Member

janober commented Feb 21, 2024

Got released with n8n@1.30.0

cstuncsik pushed a commit that referenced this pull request Feb 22, 2024
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
cstuncsik pushed a commit that referenced this pull request Feb 22, 2024
Signed-off-by: Oleg Ivaniv <me@olegivaniv.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
n8n team Authored by the n8n team Released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants