fix(editor): Make sure auto loading and auto scrolling works in executions tab #9505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
n8n-assistant
bot
added
n8n team
MiloradFilipovic
approved these changes
May 27, 2024
| autoScrollDeps: { | ||
| activeExecutionSet: false, | ||
| cardsMounted: false, | ||
| scroll: true, |
There was a problem hiding this comment.
Nit: I find this name to be a bit unclear. Can we elaborate a bit more what this flag is doing (better name, or just a comment)?
| @@ -117,6 +119,12 @@ export default defineComponent({ | |||
| data() { | |||
| return { | |||
| filter: {} as ExecutionFilterType, | |||
| mountedItems: [] as string[], | |||
There was a problem hiding this comment.
Looks like we only care about number of mounted cards here, so can we just track that instead of keeping the list of ids (I guess it will be a bit more performant for longer lists)?
There was a problem hiding this comment.
Yes, it could be just a counter but I need to get a workflow card ref by its ID and since it is used in other places (it is needed for the auto scroll) I didn't want to change the ref so it seemed better to collect the IDs
I don't think it will cause a performance issue, you would have to have like 100K (or a million) of IDs stored in the array, I don't think we will ever have that
|
|
1 failed test on run #5133 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Projects > should handle workflows and credentials and menu items |
Test Replay
Screenshots
Video
|
|
Review all test suite changes for PR #9505 ↗︎
cstuncsik
deleted the
pay-1584-executions-view-on-single-workflow-limited-to-10
branch
MiloradFilipovic
added a commit
that referenced
this pull request
May 30, 2024
* master: ci: Upgrade storybook to address CVE-2024-36361 (no-changelog) (#9541) fix(editor): Improve contrast for `--color-danger` in dark mode (no-changelog) (#9537) fix(editor): Prevent updating node parameter value if it hasn't changed (#9535) fix(editor): Show execution error toast also if there is no error stack just message (#9526) fix(editor): Prevent expression editor focus being lost when user is selecting (#9525) fix(editor): Update webhook paths when duplicating workflow (#9516) refactor(core): Increase minimum supported Node.js version to 18.17 (#9533) fix(core): Set source control repository to track remote if ready (#9532) feat(editor): Show expression infobox on hover and cursor position (#9507) fix(core): Block Public API related REST calls when Public API is not enabled (#9521) test(core): Align test names with route names (no-changelog) (#9518) refactor(core): Prevent reporting to Sentry IMAP server error (no-changelog) (#9515) fix(editor): Executions view popup in dark mode (#9517) refactor: Delete dead crash recovery code (no-changelog) (#9512) fix(editor): Send only execution id in postMessage when previewing an execution (#9514) fix(editor): Make sure auto loading and auto scrolling works in executions tab (#9505) fix(core): Fix worker encryption key warning docs link (no-changelog) (#9513) build: Bump license-sdk to v2.12.0 (no-changelog) (#9510) Revert "build: Bump license-sdk to v2.11.1 (no-changelog)" build: Bump license-sdk to v2.11.1 (no-changelog) # Conflicts: # pnpm-lock.yaml
Merged
|
Got released with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Auto loading more items and auto scrolling on the execution tab wasn't working on very tall screen size
Related tickets and issues
PAY-1584
Review / Merge checklist
(no-changelog)otherwise. (conventions)