Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/ATC-88 #94

Merged
merged 3 commits into from
Nov 16, 2016
Merged

feature/ATC-88 #94

merged 3 commits into from
Nov 16, 2016

Conversation

n8rzz
Copy link
Owner

@n8rzz n8rzz commented Nov 15, 2016 •
edited
Loading

completes #88

Moves list of airports to load out of bundle allowing for additions and removals without the need to re-build the app.

@n8rzz
feature/ATC-88 - Adds iief and additional script tag to index.html that
80f64fd 
allows for an airportLoadList isolated from the bundle and editable
without re-bundling.
* Removes src/**/airportLoadList
* Updates AirportController to use new window var
@n8rzz
feature/ATC-88 - Move AIRPORT_LOAD_LIST to index.js where it is then
5f777ab 
passed down through App and on to AirportController
@n8rzz n8rzz added the feature label Nov 15, 2016
@n8rzz n8rzz added this to the v3.1.0 milestone Nov 15, 2016
erikquinn
erikquinn reviewed Nov 15, 2016
View reviewed changes
Copy link
Collaborator

@erikquinn erikquinn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Not sure if I'm doing something wrong, but I removed ksea.json from assets/airports, and from the load list, retranspiled. It is gone from the in-game list (good). Then I added the file back in and put it back in the load list, did a simple page refresh, it is back in the in-game list (good). But then when I try to load it, it just spins, and eventually konks out here:

image

@n8rzz
Copy link
Owner Author

n8rzz commented Nov 15, 2016

Yeah, that's that other PR I have that I think you just approved. That will fix this error.

@erikquinn
Copy link
Collaborator

Gotcha. The changes all look to make sense, so I'll approve it as is then.

@n8rzz
Copy link
Owner Author

n8rzz commented Nov 15, 2016

@erikquinn just merged in the PR that fixes the areas error you were seeing here. I know you already approved this, but when you have a minute, could you test this locally? I want to be extra sure that this works before I merge.

@erikquinn
Copy link
Collaborator

@erikquinn just merged in the PR that fixes the areas error you were seeing here. I know you already approved this, but when you have a minute, could you test this locally? I want to be extra sure that this works before I merge.

Like a charm this time. 👍

@n8rzz
Copy link
Owner Author

n8rzz commented Nov 16, 2016

:shipit:

@n8rzz n8rzz merged commit 1815351 into develop Nov 16, 2016
@n8rzz n8rzz deleted the feature/ATC-88 branch November 16, 2016 03:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erikquinn erikquinn erikquinn approved these changes

Assignees

@erikquinn erikquinn

Labels
feature
Projects
None yet
Milestone
v3.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@n8rzz @erikquinn