[Question] utility/Due/RF24_arch_config.h not needed? #752
Comments
|
At one point I supported the extended SPI API for the due, but that was removed due to unnecessary complexity. I think that is why there was a folder for it in utility. Printf works out of the box, but no pgmspace.
… On Mar 22, 2021, at 4:08 AM, Brendan ***@***.***> wrote:
I couldn't find where the Arduino Due support file /utility/Due/RF24_arch_config.h file is/was getting included. There's no following snippet in the /RF24_arch_config.h
#if defined (ARDUINO_SAM_DUE)
// ARDUINO_SAM_DUE is defined using CLI args (-DARDUINO_SAM_DUE) at compile time
#include "utility/Due/RF24_arch_config.h"
#endif
So, against my better nature, I went out of my way to break Due support by commenting out everything in /utility/Due/RF24_arch_config.h and un-commenting SERIAL_DEBUG in /RF24_arch_config.h... It still compiles the same as before (I can't break Due support if I tried?! 😆 ) I suspect printf.h doesn't work for the Due either (judging from the ArduinoCore-SAM repo), but it might (using sprintf() from avr/pgmspace.h).
@TMRh20 I have a feeling I hit yet another relic from maniacBug days.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub, or unsubscribe.
|
|
Actually pgmspace was added back into the core in 2013. It now gets included in RF24_config.h (using |
|
I started re-implementing the Due's extended SPI feature, but it made the code really messy and grew the compile size quite a bit. It's not like the Due doesn't have the capacity, but we're going for "optimization" here. I also excluded #743 from Due support (properly this time) in RF24_config.h because the Due core's SPI library only supports 1 SPI bus (opposed to what the pinout may suggest). I'm going to remove the Due arch_config file to avoid any further confusion in the future. |
convert _SPI calls to pointers where applicable typo made BCM driver fail overload begin() and amended docs about begin() fix faulty #ifdef logic doxygen v1.9.1 deprecated COLS_IN_ALPHA_INDEX tag bump version to v1.4.0 exclude only RF24_LINUX apply ptr treatment to Teensy, LittleWire, & Due trigger ArduinoCLI action doxygen action shouldn't create a docs folder no need to specify output dir in doxygen action make my life simpler: use new RF24_SPI_PTR macro trigger ArduinoCLI action forgot about c'tor; fix 2-space indent in begin() abstract SPI::begin() from _init_pins() adjust csn_pin before SPI.begin() on BCM driver conforming whitespace add printf.h fix from @TonioChingon in nRF24#739 rename atxmega.md & add link to supported product add Due to ArduinoCLI action fix teensy support; add PIO CI for teensy [PIO CI] use quoted matrix entries [PIO CI] use single quotes? I hate YML Gimme that badge add MRAA to Linux CI action typo [Linux CI] MRAA install needs special permission try with "sudo bash -c" [Linux CI] MRAA not cross compiling (I think) add example code snippets to Arduino support pg doc typos Due can't use SPI_PTR; delete ATXMEGA/readme.md (use docs/atxmega.md instead) fix nRF24#414; note need mbed example in arduino.md fix printf() only for adafruit/ArduinoCore-SAMD add msg about COMMON_ISSUES to README add estimated mbed example to arduino.md avr/pgmspace.h was added to Due core in 2013 oops, undo my testing change remove useless Due config file nRF24#752 ammend support for SPI_UART in csn() Confirm working 2nd SPI bus on esp8266 nRF24#648 fix indent c-n-p artifact; more indent inconcsistencies comment out theroretical example snippets add pinout img from RF24Audio repo doxygen sux at reading imgs implement nRF24#539 my CnP skills are lacking need to test py wrapper [py_wrap] begin fails to compile [py wrap] oops left the old begin still in there [py wrap] use thin wrapper for begin_w/_pins [pr wrap] try explicit begin(void) boost.py docs suck [py wrap] try using same name for begin(pin, pin) [py wrap] c'tor overload is bad [py wrap] "optional<>" template didn't take [py wrap] unmatched parenthesis advise that teensy doesn't need overloaded begin() docs review
I couldn't find where the Arduino Due support file /utility/Due/RF24_arch_config.h file is/was getting included. There's no following snippet in the /RF24_config.h
So, against my better nature, I went out of my way to break Due support by commenting out everything in /utility/Due/RF24_arch_config.h and un-commenting
SERIAL_DEBUGin /RF24_config.h (& also calledprintDetails()in GettingStarted.ino)... It still compiles the same as before (I can't break Due support if I tried?! 😆 ) I suspect printf.h doesn't work for the Due either (judging from the ArduinoCore-SAM repo), but it might (usingsprintf()from avr/pgmspace.h).@TMRh20 I have a feeling I hit yet another relic from maniacBug days.
The text was updated successfully, but these errors were encountered: