Alias gpio pin datatype #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Memory usage change @ ea66839
Click for full report table
Click for full report CSV |
|
I'm assuming that report is measured in bytes. Didn't expect the ATTiny to have that much improvement! |
|
Nice |
2bndy5
force-pushed
the
alias-gpio-pin-datatype
branch
from
7d42b3f
to
bdc8bbb
Compare
|
I hardware tested this on Pico SDK (while I still had the HW setup for addressing #899); test went well. I also added a follow up to the 557d165 that removed a useless I also fixed compiler warnings about the magic numbers used when the pin numbers are not passed to the RF24 c'tor. |
includes a follow up from 557d165 in which a useless RF24::spi member was declared for RP2040 platform.
This will fix RF24::isValid() and prevents overflow from using the old 0xFFFF value in the RF24 overloaded c'tor that accepts no args. It also helps to avoid "magic numbers" as was previously used.
2bndy5
force-pushed
the
alias-gpio-pin-datatype
branch
from
bdc8bbb
to
832538d
Compare
|
I tested this on Arduino (Feather RP2040) and Linux (SPIDEV and MRAA drivers). I'm going to modify the examples to replace the "magic numbers" passed to the c'tor with defines: #define CSN_PIN 0
#ifdef MRAA
#define CE_PIN 15 // GPIO22
#else
#define CE_PIN 22
#endif
// Generic:
RF24 radio(CE_PIN, CSN_PIN);This way it is explicit what the numbers represent in the c'tor args. |
TMRh20
approved these changes
Apr 22, 2023
2bndy5
added a commit
to nRF24/pyRF24
that referenced
this pull request
Dec 4, 2023
This is actually an overlooked follow up to nRF24/RF24#898 The problematic inconsistency was primarily affecting builds with the RPi driver.
2bndy5
added a commit
to nRF24/pyRF24
that referenced
this pull request
Dec 5, 2023
This is actually an overlooked follow up to nRF24/RF24#898 The problematic inconsistency was primarily affecting builds with the RPi driver.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #896