Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nrf52 support #37

Merged
merged 5 commits into from
Jun 22, 2023
Merged

Nrf52 support #37

merged 5 commits into from
Jun 22, 2023

Conversation

TMRh20
Copy link
Member

@TMRh20 TMRh20 commented Jun 7, 2023

Support NRF52 devices

@TMRh20 TMRh20 requested a review from 2bndy5 June 7, 2023 00:29
2bndy5
2bndy5 reviewed Jun 7, 2023
View reviewed changes
Copy link
Member

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably add a notice in the README that these changes prohibit nRF24L usage on boards based on the nRF5x family.

RF24Ethernet.h Outdated Show resolved Hide resolved
@TMRh20 TMRh20 requested a review from 2bndy5 June 7, 2023 00:49
2bndy5
2bndy5 reviewed Jun 7, 2023
View reviewed changes
README.md Show resolved Hide resolved
@TMRh20 @2bndy5
Update README.md
d560cb2 
Co-authored-by: Brendan <2bndy5@gmail.com>
2bndy5
2bndy5 approved these changes Jun 7, 2023
View reviewed changes
Copy link
Member

@2bndy5 2bndy5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming you tested these changes with HW. This TCP/IP stuff is beyond my skill set.

@TMRh20
Copy link
Member Author

TMRh20 commented Jun 7, 2023

Yup, tested on a Feather and XIAO Sense.

@TMRh20 TMRh20 merged commit 8c12396 into master Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2bndy5 2bndy5 2bndy5 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TMRh20 @2bndy5