Simplify connection timeouts more #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Realized that the timeout var is set when data is allocated initially - No need for initialData variable - Move connection timeout after data is allocated (timeout is set to millis())
|
Planning on doing a release after this commit |
2bndy5
approved these changes
Oct 22, 2023
|
I should probably add a trigger to the PIO CI to check for formatting on push events. RF24Ethernet/.github/workflows/build_platformIO.yml Lines 10 to 14 in 368a8ef Some added paths of a glob patterns should do the trick push:
paths:
- ".github/workflows/build_platformIO.yml"
- "library.json"
- "examples/**"
+ - "*.cpp"
+ - "*.h"Our other repos (except RF24Audio) all rely on the Linux CI to check formatting in the Library source code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kind of hate to do another PR right away like this, but I will give this one a while before merging in case I find any other optimizations etc.