Fix mesh.begin() #214
Merged
Fix mesh.begin() #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
TMRh20
commented
Jul 10, 2022
TMRh20
commented
- Begin will return true by mistake because of recent changes to the renewAddress() function
- See https://github.com/nRF24/RF24Mesh/blob/FixBegin()/RF24Mesh.cpp#L39
- Begin will return true by mistake because of recent changes to the renewAddress() function
2bndy5
approved these changes
Jul 10, 2022
|
Oh I didn't see the file name. I thought this was an example. I really should do a search for all calls to |
|
That seems to be the last one. This should get a priority release after merging. |
I was thinking the same thing. 👍 |
|
You wanna do the release (& try the fancy new auto-generate summary button)? |
|
I pushed the version bump in the lib info files. I'm publish the release now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.