Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump RF24 from 9eca153 to 05efe34 #41

Closed
wants to merge 1 commit into from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Mar 18, 2024

Bumps RF24 from 9eca153 to 05efe34.

Commits
  • 05efe34 Update SPIDEV driver for Character Device v2 ABI; cache FDs (#959)
  • 9d0aa8d fix scanner.py; draw 1 space (not 2) after channel label
  • ef08a40 Promiscuous scanners (#955)
  • 7e97360 separate ISR handling from IRQ processing (#956)
  • See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [RF24](https://github.com/nRF24/RF24) from `9eca153` to `05efe34`.
- [Release notes](https://github.com/nRF24/RF24/releases)
- [Commits](nRF24/RF24@9eca153...05efe34)

---
updated-dependencies:
- dependency-name: RF24
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code labels Mar 18, 2024
@2bndy5
Copy link
Member

2bndy5 commented Mar 18, 2024

ef08a40 Promiscuous scanners (#955)

I should probably update the scanner example in this repo as well as add a scanner_curses.py example.

@2bndy5
Copy link
Member

2bndy5 commented Mar 18, 2024

Oh, the CI is failing to build docs because the new GPIO chip resolution fails on the CI runner.

reading sources... [ 14%] ble_api
terminate called after throwing an instance of 'GPIOException'
  what():  Can't open device /dev/gpiochip0; No such file or directory
/home/runner/work/_temp/c01082ef-96ba-457b-9cb3-764f9f1b9535.sh: line 1:  3614 Aborted                 (core dumped) sphinx-build -E -W -b html . _build/html
Error: Process completed with exit code 134.

Not sure how to work around this. Sphinx is obviously executing the code it loads as it parses src/pyrf24/fake_ble.py for docs strings.

@2bndy5
Copy link
Member

2bndy5 commented Mar 18, 2024

The only way I can see about working around the thrown GPIOException (during CI docs build and possibly other python static analysis tools like pylint) is to alter the upstream C++.

  1. (in gpio.cpp) Move the gpiochipX resolution into the GPIO::open()
  2. (in interrupt.cpp) Move the gpiochipX resolution into attachInterrupt()

I can make these changes in nRF24/RF24#961, but we'll have to re-test things again.

@2bndy5
Copy link
Member

2bndy5 commented Mar 18, 2024

Oh, the CI is failing to build docs because the new GPIO chip resolution fails on the CI runner.

confirmed that this is fixed in nRF24/RF24#961

@2bndy5 2bndy5 closed this Mar 18, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 18, 2024

OK, I won't notify you again about this release, but will get in touch when a new version is available. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot dependabot bot deleted the dependabot/submodules/RF24-05efe34 branch March 18, 2024 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant