Allow windows users to run commands #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
child_process.spawn was not working with npm commands on windows. I would have to run npm.cmd instead.
bmwynne
approved these changes
Sep 19, 2019
savvyintegrations
approved these changes
Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When setting up the Elivagar stack using windows I ran into an error when packaging lambdas.
Pulling down the repo and investigator further revealed that spawn doesn't execute npm commands in windows: nodejs/node#3675.
nodejs/node#3675 (comment)
Node docs: https://nodejs.org/api/child_process.html#child_process_default_windows_shell
Please test.