loading JSON translations #412
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello, What does this do if there are no json files in the folder? |
|
@nWidart look , laravel/framework#20599 😃 |
|
Thanks, though this seems to be adding I/O operations. Don't you think it's easy for someone who wants json translations to add it? Maybe it could be documented on the docs. |
mikemand
suggested changes
Nov 8, 2017
| @@ -190,6 +190,7 @@ protected function registerTranslation() | |||
|
|
|||
| if (is_dir($langPath)) { | |||
| $this->loadTranslationsFrom($langPath, $lowerName); | |||
| $this->loadJSONTranslationsFrom($langPath); | |||
There was a problem hiding this comment.
This should be loadJsonTranslationsFrom. JSON is not capitalized: Illuminate/Support/ServiceProvider.php#L107-L116
|
Thank you for the contribution, but this is something that's easily added manually and avoids extra load. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.