Skip to content
This repository has been archived by the owner on Apr 9, 2023. It is now read-only.

Add kind type #30

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Add kind type #30

merged 1 commit into from
Jan 5, 2022

Conversation

gemmaro
Copy link
Contributor

@gemmaro gemmaro commented Jan 3, 2022

駒の種類の型 Kind を定義します。

  • Add test for Kind (?) (for passing coverage)

@na2hiro
Copy link
Owner

na2hiro commented Jan 5, 2022

LGTM!

Do you plan to add more changes? If you marked this as a draft because of lack of tests, then I think it's ready to merge.

@gemmaro gemmaro marked this pull request as ready for review January 5, 2022 03:22
@gemmaro
Copy link
Contributor Author

gemmaro commented Jan 5, 2022

Thank you! Ready for review now.

@na2hiro na2hiro merged commit 019a9fb into na2hiro:master Jan 5, 2022
@na2hiro
Copy link
Owner

na2hiro commented Jan 5, 2022

Travis CI was disabled because I didn't perform migration from travis-ci.org to travis-ci.com. I clicked migrate button and it should be enabled now.

Let's merge this and check the status in master branch

@gemmaro gemmaro deleted the add-kind branch January 5, 2022 13:40
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants