Fix?(server): Content-Dispositionのパースでエラーが発生した場合にもダウンロードが完了するように

misskey-dev#10626
na2na-p · May 10, 2023 · a95524c · a95524c
1 parent 66c9c62
commit a95524c
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/packages/backend/src/core/DownloadService.ts b/packages/backend/src/core/DownloadService.ts
@@ -86,9 +86,13 @@ export class DownloadService {
 
  const contentDisposition = res.headers['content-disposition'];
  if (contentDisposition != null) {
- const parsed = parse(contentDisposition);
- if (parsed.parameters.filename) {
- filename = parsed.parameters.filename;
+ try {
+ const parsed = parse(contentDisposition);
+ if (parsed.parameters.filename) {
+ filename = parsed.parameters.filename;
+ }
+ } catch (e) {
+ this.logger.warn(`Failed to parse content-disposition: ${contentDisposition}`, { stack: e });
  }
  }
  }).on('downloadProgress', (progress: Got.Progress) => {