Replace semver/semver by nikolaposa/version (#1754)

* Apply fixes from StyleCI * Replace semver/semver by nikolaposa/version * Update composer.lock * Update composer.lock * Update composer.lock --------- Co-authored-by: StyleCI Bot <bot@styleci.io> Co-authored-by: Nabeel S <nabeelio@users.noreply.github.com>
nabeelio · Mar 5, 2024 · 1f5b83b · 1f5b83b
1 parent 15bac3a
commit 1f5b83b
Show file tree

Hide file tree

Showing 5 changed files with 137 additions and 64 deletions.
diff --git a/app/Console/Commands/Version.php b/app/Console/Commands/Version.php
@@ -39,14 +39,14 @@ public function handle()
 
             // If a version is being passed in, the update the build, etc data against this
             if ($this->argument('version')) {
-                $version = \SemVer\SemVer\Version::fromString($this->argument('version'));
+                $version = \Version\Version::fromString($this->argument('version'));
                 if ($this->option('write-full-version')) {
                     $cfg['current']['major'] = $version->getMajor();
                     $cfg['current']['minor'] = $version->getMinor();
                     $cfg['current']['patch'] = $version->getPatch();
                 }
 
-                $prerelease = $version->getPreRelease();
+                $prerelease = $version->getPreRelease()?->toString();
                 if (strpos($prerelease, '.') !== false) {
                     $prerelease = explode('.', $prerelease);
                     $cfg['current']['prerelease'] = $prerelease[0];

diff --git a/app/Services/VersionService.php b/app/Services/VersionService.php
@@ -7,8 +7,8 @@
 use App\Support\HttpClient;
 use GuzzleHttp\Exception\GuzzleException;
 use Illuminate\Support\Facades\Log;
-use SemVer\SemVer\Version;
 use Symfony\Component\Yaml\Yaml;
+use Version\Version;
 
 class VersionService extends Service
 {
@@ -232,8 +232,8 @@ public function isNewVersionAvailable($current_version = null)
      */
     public function isGreaterThan($version1, $version2): bool
     {
-        $version1 = Version::fromString($version1);
-        $version2 = Version::fromString($version2);
-        return $version1->isGreaterThan($version2);
+        $parsedVersion1 = Version::fromString($version1);
+        $parsedVersion2 = Version::fromString($version2);
+        return $parsedVersion1->isGreaterThan($parsedVersion2);
     }
 }
diff --git a/composer.json b/composer.json
@@ -64,7 +64,6 @@
         "phpvms/sample-module": "~1.0",
         "prettus/l5-repository": "~2.9.0",
         "santigarcor/laratrust": "^8.2.2",
-        "semver/semver": "~1.1.0",
         "spatie/valuestore": "~1.3.2",
         "tivie/php-os-detector": "~1.1.0",
         "vlucas/phpdotenv": "~5.5",
@@ -88,7 +87,8 @@
         "symfony/postmark-mailer": "^6.0",
         "league/html-to-markdown": "^5.1",
         "league/flysystem-aws-s3-v3": "^3.0",
-        "league/flysystem-sftp-v3": "^3.0"
+        "league/flysystem-sftp-v3": "^3.0",
+        "nikolaposa/version": "^4.2"
     },
     "require-dev": {
         "barryvdh/laravel-debugbar": "^3.8.1",

diff --git a/composer.lock b/composer.lock
diff --git a/symfony.lock b/symfony.lock
@@ -403,9 +403,6 @@
     "sempro/phpunit-pretty-print": {
         "version": "1.4.0"
     },
-    "semver/semver": {
-        "version": "1.1.0"
-    },
     "spatie/backtrace": {
         "version": "1.2.1"
     },