Properly set the distance/planned_distance on save (#497)

nabeelio · Jan 14, 2020 · aafc968 · aafc968
1 parent 9aded3a
commit aafc968
Showing 1 changed file with 5 additions and 7 deletions.
diff --git a/app/Models/Pirep.php b/app/Models/Pirep.php
@@ -260,16 +260,14 @@ public function getReadOnlyAttribute(): bool
      */
     public function getProgressPercentAttribute()
     {
-        $upper_bound = $this->distance['nmi'];
-        if ($this->planned_distance) {
-            $upper_bound = $this->planned_distance['nmi'];
-        }
+        $distance = $this->distance;
 
-        if (!$upper_bound) {
-            $upper_bound = 1;
+        $upper_bound = $distance;
+        if ($this->planned_distance) {
+            $upper_bound = $this->planned_distance;
         }
 
-        return round(($this->distance['nmi'] / $upper_bound) * 100, 0);
+        return round(($distance / $upper_bound) * 100, 0);
     }
 
     /**