Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API Items need #120

Closed
4 of 7 tasks
lorathon opened this issue Jan 5, 2018 · 9 comments
Closed
4 of 7 tasks

API Items need #120

lorathon opened this issue Jan 5, 2018 · 9 comments
Milestone

Comments

@lorathon
Copy link

lorathon commented Jan 5, 2018

Some of the following would be nice to have. Some may be pointless. Some may come later

  • GET All Airports
  • GET Aircraft info (based on id | reg | tail number)
  • GET All Aircraft
  • POST Schedule Search (based on dep/arr/aircraft/etc... One, two or all....)
  • GET users on line
  • On POST of ACARS update data return time remaining? (this may not be needed)
  • POST PIREP Prefile return is missing arr airport data. Only dep airport data included
@nabeelio
Copy link
Owner

nabeelio commented Jan 5, 2018

Why a POST for the flight search? There is a GET for it, I haven't documented it yet, but it's /api/flights/search, see this for the URL params

So /api/flights/search?depicao=KJFK. I need to add more parameters, I have a ticket for distance/level parameters maybe

What do you mean by time remaining? Against the filed time? I don't really run any of those calculations right now, but it's something I could potentially do.

@nabeelio
Copy link
Owner

nabeelio commented Jan 5, 2018

RE: Users online - is this more the currently active flights, or you want to know who's actually logged in? For active flights, I have that built already, just needs the REST interface. For who's actually on, that'd be a bit more involved and would need some updates, but doable.

@lorathon
Copy link
Author

lorathon commented Jan 5, 2018

The POST should have been a GET (sorry)

Time remaining not really necessary but was with the old phpvms. Live flights for the GET on users would be fine.

@nabeelio
Copy link
Owner

nabeelio commented Jan 5, 2018

Would you want it as a list of users, with the active PIREP, or inverted with the IN_PROGRESS PIREPs with the user info? Though I can probably just do both as separate calls

@lorathon
Copy link
Author

lorathon commented Jan 5, 2018

List of users with pirep

@nabeelio nabeelio added the api label Jan 5, 2018
@nabeelio nabeelio added this to the alpha milestone Jan 5, 2018
@nabeelio
Copy link
Owner

nabeelio commented Jan 5, 2018

I've added the aircraft list, I'm going to update the docs once I push it up, but you probably want another one that I haven't added yet (I will this weekend)... it will be like /api/user/flight, which will return to you the the aircraft that the user has permission to (as-per what's assigned to their rank)

@nabeelio
Copy link
Owner

nabeelio commented Jan 5, 2018

The other thing for the flights search, I'm adding in the day-of-week specifier. I'm also adding a setting to be strict about "flights for today", which, if it's enabled, if today is a Tuesday, it will only return flights that are available on Tuesdays.

There's another setting that is a restriction on flights only from their hub being available, it will further restrict based on that. You won't have to do anything to handle those, but just so you're aware of if you're doing a flight search and those settings are enabled, then you might not get results back.

The same filtering will apply on the web interface.

@nabeelio
Copy link
Owner

nabeelio commented Jan 6, 2018

Added a few more APIs:

  • /api/airlines - Paginated list of the airlines
  • /api/airlines/{ID} - Get info about a specific airline
  • /api/flights - Paginated list of all of the flights
  • /api/settings to retrieve the VA settings, like the weight units, etc.

@nabeelio
Copy link
Owner

Closing this to consolidate tickets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants