Added Japanese Language #1884
Merged
Added Japanese Language #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FatihKoz
reviewed
Sep 30, 2024
|
Additionally to above suggested style fix (change of double quotes to single ones) , |
BossOfGames
suggested changes
Sep 30, 2024
|
Hi @minnsch there were a few comments, can you resolve those and then I'll merge? Thank you!! |
BossOfGames
approved these changes
Nov 11, 2024
There was a problem hiding this comment.
Ran this by my wife one more time. She says everything is good. @nabeelio this is good to merge when ready.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.