Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Japanese Language #1884

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Added Japanese Language #1884

wants to merge 3 commits into from

Conversation

minnsch
Copy link

@minnsch minnsch commented Sep 30, 2024

No description provided.

@@ -0,0 +1,80 @@
<?php
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file should NOT be included in this PR.

It is being shipped by a 3rd party addon already.

@FatihKoz
Copy link
Contributor

image

Additionally to above suggested style fix (change of double quotes to single ones) , disposable.php should be removed from the PR completely.

Copy link
Contributor

@BossOfGames BossOfGames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall Good. Verified by my spouse who's a native Japanese speaker.

'tocaccept' => '登録することで, あなたは規約に同意する。',
'register' => '新規登録',
'registrationpending' => '登録待機中',
'pendingmessage' => 'ANAバーチャルグループへの新規登録誠にありがとうございます。私たちの管理員がアカウントの確認をしています。少々お待ちください!(1300z ~ 2200zは管理員の休憩時間です。多少の遅れが生じます)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in reference to a specific VA. Please change this to something more generic, in line with the original

'pendingmessage' => 'ANAバーチャルグループへの新規登録誠にありがとうございます。私たちの管理員がアカウントの確認をしています。少々お待ちください!(1300z ~ 2200zは管理員の休憩時間です。多少の遅れが生じます)',
'registrationsubmitted' => '登録提出済み',
'registrationconfirmation' => '登録の確認',
'confirmationmessage' => 'ANAバーチャルグループへの新規登録誠にありがとうございます。私たちの管理員がアカウントの確認をしています。少々お待ちください!(1300z ~ 2200zは管理員の休憩時間です。多少の遅れが生じます)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is in reference to a specific VA. Please change this to something more generic, in line with the original


return [
'ident' => 'ID',
'home' => '実家空港',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

拠点空港(または拠点)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants