-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SimBrief Airframes & Aircraft Weight Casting #1892
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the 'kg' is selected as weight unit.
Provide some weights
Add weight to importer
@nabeelio I simply dashed out weights checks against factory created aircraft. ApiTest.php, lines 324-325, 332-333, 343-344 as it was not possible to pass the Currently live testing on my server, found no problems with vmsAcars usage so far. |
Ref PilotID should be used.
arthurpar06
reviewed
Nov 17, 2024
app/Database/migrations/2024_11_16_105923_create_simbrief_support_tables.php
Outdated
Show resolved
Hide resolved
For separating Internal / External airframes
nabeelio
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR allows fetching/storing SimBrief airframes and layout data, which can be used during flight planning via API. Also allows the admins to add their custom SimBrief airframes to phpvms easily.
Automated relationship works by
ICAO Type Code
of the aircraft, also it is still possible to define aircraft and subfleet level simbrief airframes (viasimbrief_type
field)By default initial data fetching is done during install, also scheduled to be run with weekly cron, additionally manually triggering the process is possible. (via admin > sb airframes)
Also Aircraft weights are now casted as
Mass Units
, before they were just plain values not being used by the system.SimBrief flight planning is enhanced to benefit from both the airframe selections and aircraft weights/data. Controller, blade and jscript changes are present. Two additional settings are introduced to control new features.
PR provides a simple kg (local) to lbs (internal) conversion for already saved aircraft weights if the VA is using
kg
as weight unit and assuming that the weights was saved inkg
. If this is not the case, exported csv will fix the mess.Closes #1304