Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SimBrief Airframes & Aircraft Weight Casting #1892

Merged
merged 19 commits into from
Nov 18, 2024
Merged

Conversation

FatihKoz
Copy link
Contributor

PR allows fetching/storing SimBrief airframes and layout data, which can be used during flight planning via API. Also allows the admins to add their custom SimBrief airframes to phpvms easily.

Automated relationship works by ICAO Type Code of the aircraft, also it is still possible to define aircraft and subfleet level simbrief airframes (via simbrief_type field)

By default initial data fetching is done during install, also scheduled to be run with weekly cron, additionally manually triggering the process is possible. (via admin > sb airframes)

Also Aircraft weights are now casted as Mass Units, before they were just plain values not being used by the system.

SimBrief flight planning is enhanced to benefit from both the airframe selections and aircraft weights/data. Controller, blade and jscript changes are present. Two additional settings are introduced to control new features.

⚠️ WARNING: It is best to export aircraft before applying this update ⚠️

PR provides a simple kg (local) to lbs (internal) conversion for already saved aircraft weights if the VA is using kg as weight unit and assuming that the weights was saved in kg . If this is not the case, exported csv will fix the mess.

Closes #1304

image

image

image

image

image

image

@FatihKoz
Copy link
Contributor Author

FatihKoz commented Nov 17, 2024

@nabeelio I simply dashed out weights checks against factory created aircraft.

ApiTest.php, lines 324-325, 332-333, 343-344 as it was not possible to pass the 93000.0 does not match expected type "array". return of the test.

70494b0

Currently live testing on my server, found no problems with vmsAcars usage so far.

Ref PilotID should be used.
@nabeelio nabeelio merged commit 5862b40 into nabeelio:dev Nov 18, 2024
7 checks passed
@FatihKoz FatihKoz deleted the SimBrief branch November 18, 2024 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Aircraft Characteristics in Simbrief an Alternative to Custom Airframes
3 participants