UI test for "Login" and "Create File" Feature of File Browser #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aakrity17
force-pushed
the
akrity-ui-test-for-login
branch
2 times, most recently
from
4db8c45 to
783895e
Compare
aakrity17
requested review from
SagarGi,
Yogesh070,
nabim777,
S-Panta,
Grisha596 and
SoniGautam
aakrity17
changed the title
aakrity17
changed the title
Grisha596
reviewed
Dec 19, 2023
| @@ -0,0 +1,34 @@ | |||
| const { expect } = require("playwright/test") | |||
|
|
|||
|
|
|||
Grisha596
reviewed
Dec 19, 2023
Comment on lines
6
to
8
|
|
||
| //define selectors | ||
| // this.newFolderSelector = '//button[@title="New folder"]' |
There was a problem hiding this comment.
Suggested change
| //define selectors | |
| // this.newFolderSelector = '//button[@title="New folder"]' |
Grisha596
reviewed
Dec 19, 2023
| this.textButtonSelector = '//input[@class="input input--block"]' | ||
| this.createButtonSelector='//button[@title="Create"]' | ||
| this.textFieldSelector='//textarea[@class="ace_text-input"]' | ||
| // this.textFieldSelector= '//div[@class="ace_content"]' |
There was a problem hiding this comment.
Suggested change
| // this.textFieldSelector= '//div[@class="ace_content"]' |
Grisha596
reviewed
Dec 19, 2023
Comment on lines
29
to
31
|
|
||
|
|
||
|
|
Grisha596
reviewed
Dec 19, 2023
|
|
||
|
|
||
| } | ||
|
|
Grisha596
reviewed
Dec 19, 2023
| await page.fill(this.passwordSelector, password); | ||
| await page.click(this.loginButtonSelector); | ||
| } | ||
| } |
Grisha596
reviewed
Dec 19, 2023
| And the user has logged in with username "admin123" and password "12345" using webUI | ||
| When the user creates a new file "test.txt" with content "Hello World!!!" | ||
| Then the user should be able to see "test.txt" file | ||
|
|
Grisha596
reviewed
Dec 19, 2023
Comment on lines
12
to
13
| } | ||
| ); |
There was a problem hiding this comment.
Suggested change
| } | |
| ); | |
| }); |
Grisha596
reviewed
Dec 19, 2023
Comment on lines
18
to
19
| } | ||
| ); |
There was a problem hiding this comment.
Suggested change
| } | |
| ); | |
| }); |
Grisha596
reviewed
Dec 19, 2023
| const { Given, When, Then } = require('@cucumber/cucumber') | ||
| const { expect } = require("@playwright/test") | ||
| const assert = require("assert") | ||
| const LoginPage = require("../PageObjects/LoginPage.js") |
There was a problem hiding this comment.
Suggested change
| const LoginPage = require("../PageObjects/LoginPage.js") | |
| const LoginPage = require("../PageObjects/LoginPage.js") |
Grisha596
reviewed
Dec 19, 2023
| const { expect } = require("@playwright/test") | ||
| const assert = require("assert") | ||
| const LoginPage = require("../PageObjects/LoginPage.js") | ||
|
|
nabim777
reviewed
Dec 19, 2023
| //launch url | ||
| this.serverUrl = 'http://localhost:8080/'; | ||
| this.loginUrl = this.serverUrl+"login"; | ||
| // this.loginUrl = this.serverUrl+"login"; |
There was a problem hiding this comment.
Suggested change
| // this.loginUrl = this.serverUrl+"login"; |
nabim777
reviewed
Dec 19, 2023
|
|
||
| Scenario: creates a new text file | ||
| Given the user has browsed to the login page | ||
| And the user has logged in with username "admin123" and password "12345" using webUI |
There was a problem hiding this comment.
make admin id and password as default otherwise It will came problem in CI
Suggested change
| And the user has logged in with username "admin123" and password "12345" using webUI | |
| And the user has logged in with username "admin" and password "admin" using webUI |
nabim777
reviewed
Dec 19, 2023
|
|
||
|
|
||
| Scenario: User Login with correct username and valid password | ||
| When user logs in with username "admin123" and password "12345" |
There was a problem hiding this comment.
same comment https://github.com/nabim777/mentorship2023/pull/6/files#r1432036807
Suggested change
| When user logs in with username "admin123" and password "12345" | |
| When user logs in with username "admin" and password "admin" |
nabim777
reviewed
Dec 19, 2023
nabim777
reviewed
Dec 19, 2023
nabim777
reviewed
Dec 19, 2023
nabim777
reviewed
Dec 19, 2023
nabim777
reviewed
Dec 20, 2023
aakrity17
force-pushed
the
akrity-ui-test-for-login
branch
from
a4aaee8 to
c67d694
Compare
nabim777
force-pushed
the
akrity-ui-test-for-login
branch
2 times, most recently
from
1cbeaf6 to
fb9fcd1
Compare
nabim777
force-pushed
the
akrity-ui-test-for-login
branch
from
fb9fcd1 to
54ab73b
Compare
nabim777
approved these changes
Feb 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces comprehensive UI tests for two essential features within the File Browser application: "Login" and "Create File."