Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add-registry-to-user-mgmt #94

Merged
merged 65 commits into from
Sep 24, 2024
Merged

Add-registry-to-user-mgmt #94

merged 65 commits into from
Sep 24, 2024

Conversation

bjkeller
Copy link
Contributor

Changes user management gear to use the comanage registry.

  1. Creates registry record for new users in directory.
  2. Creates new Flywheel users for claimed registry record.
  3. Sends notification emails

@bjkeller
Disable linter on coreapi
3520cca
@bjkeller
Add user registry class
8eb3e78
@bjkeller
Refactor registry methods
f2c4891
@bjkeller
Use comanage classes instead of dict
70f076a
@bjkeller
Update user-management docs
075260e
@bjkeller
Add draft changes to user mgmt
fcfbc54
@bjkeller
Update user mgmt run
2a69b4c
@bjkeller
Fix user entry loop
58c4890
@bjkeller
Refactor user directory entry
9492e38
@bjkeller
Modify user registry classes to support user management
165ee9c
@bjkeller
Add registry calls to user management
66066b4
@bjkeller
Add email notifications to common
b3279ab
@bjkeller
Add email to user management gear
092ef3d
@bjkeller
Switch from message content to template data model
c6aa32e
@bjkeller
Update send email calls
c066e34
@bjkeller
Add get admin project to nacc group
61aac79
@bjkeller
Track date in registry
e417abd
@bjkeller
Factor out common message components
7b4afc5
@bjkeller
Factor out methods for case converstion
a6b1ccb
@bjkeller
Fix typo in method name
147d445
@bjkeller
Format code
059a23e
@bjkeller
Add comanage and notification parameters
2d92445
@bjkeller
Add registry metadata class
36a11a6
@bjkeller
Add person creation dates to user registry
5972a2d
@bjkeller
Fix spelling in method name
266179b
@bjkeller
Remove registry metadata
fe11ff2
@bjkeller
Use coperson.meta creation date instead of registry data
7d2734d
@bjkeller
Allow for creation date to be None
e5d2082
@bjkeller
Remove registry metadata
38bddb8
@bjkeller
Add parameters to manifest
2a07c42
@bjkeller
Merge branch 'main' into add-registry-to-user-mgmt
9c4ddba
@bjkeller
Merge branch 'main' into add-registry-to-user-mgmt
94a28be
@bjkeller
Rebuild lockfiles after pants upgrade
2f9d4ec
@bjkeller
Fix a comment in center group
ec66d58
@bjkeller
Rename test file
1e3fde1
@bjkeller
Simplify directory class and clean up tests
84f92ea
@bjkeller
Remove unused imports
4ba546c
@bjkeller
Merge branch 'add-registry-to-user-mgmt' into update-directory-entry
63b4b57
@bjkeller
Edit merged directory
ee7d606
@bjkeller
Format directory code
2289931
@bjkeller
Fix formatting
6664a96
@bjkeller
Skip mypy for comanage
53b6815
@bjkeller
Make create for active user entry
031fab4
@bjkeller
Update user management run for changes to directory entries
5ef88ad
@bjkeller
Update user mgmt gear main to use changes to directory entries
c67d809
@bjkeller
Add get method to directory
dc270ea
@bjkeller
simplify pull-directory
398a00e
@bjkeller
Merge branch 'main' into update-directory-entry
508bd82
@bjkeller
Remove user directory and add user entry root model
7cdeb27
@bjkeller
Add tests for user entry list root model
5a3eca9
@bjkeller
Change pull-directory to use user entry list root model
8123e4b
@bjkeller
Refactor user management main
4a90ddb 
Refactor user management main:
1. Remove add_user method
2. Use auth_email instead of email when working with registry.
3. Factor out email notification methods
@bjkeller
Change get user list to only include user entries with auth email set
95ed6af
hewanadun
hewanadun approved these changes Sep 23, 2024
View reviewed changes
Copy link
Contributor

@hewanadun hewanadun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

docs/user_management/index.md Show resolved Hide resolved
gear/user_management/src/python/user_app/run.py Show resolved Hide resolved
gear/user_management/src/python/user_app/main.py Show resolved Hide resolved
gear/user_management/src/python/user_app/main.py Show resolved Hide resolved
@hewanadun
Copy link
Contributor

Noticed that study_id is set to 'adrc' when setting user permissions in Flywheel, hope this is intentional and managing other studies is a future task?

@bjkeller
Copy link
Contributor Author

In the Authorization class? That's a default. There are tests demonstrating using a different study id

@bjkeller bjkeller merged commit 946df07 into main Sep 24, 2024
@bjkeller bjkeller deleted the add-registry-to-user-mgmt branch September 24, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hewanadun hewanadun hewanadun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bjkeller @hewanadun