Skip to content
This repository has been archived by the owner on Nov 5, 2024. It is now read-only.

Fixed 'remove' command exception #111

Merged
merged 1 commit into from
Oct 19, 2022
Merged

Fixed 'remove' command exception #111

merged 1 commit into from
Oct 19, 2022

Conversation

doiska
Copy link
Contributor

@doiska doiska commented Oct 19, 2022

Hi! I found a bug in the stable version of Ultra, when using "ultra remove package-name" it throws an exception if not found in peerDependencies.

[Ultra] v0.7.0 (83.54ms)
file:///C:/Users/doiska/Documents/Tools/nvm/v16.16.0/node_modules/ultra-pkg/build/commands/remove.js:15
        delete pkg.peerDependencies[arg];
                                    ^

TypeError: Cannot convert undefined or null to object
    at remove (file:///C:/Users/doiska/Documents/Tools/nvm/v16.16.0/node_modules/ultra-pkg/build/commands/remove.js:15:37)
    at commands (file:///C:/Users/doiska/Documents/Tools/nvm/v16.16.0/node_modules/ultra-pkg/build/commands/index.js:107:16)

@vercel
Copy link

vercel bot commented Oct 19, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
fnpm ✅ Ready (Inspect) Visit Preview Oct 19, 2022 at 1:50PM (UTC)

@nachoaldamav nachoaldamav changed the base branch from main to development October 19, 2022 14:46
@nachoaldamav
Copy link
Owner

Oh thanks!! I didn't check the remove command 😅

@nachoaldamav nachoaldamav merged commit 2ba9f3a into nachoaldamav:development Oct 19, 2022
@nachoaldamav
Copy link
Owner

I will merge into main later today

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants