Use eth_chainId when signing transactions (web3#3097)

* Use eth_chainId when signing transactions
nachomazzara · Jun 4, 2020 · 23063ab · 23063ab
1 parent a25f75c
commit 23063ab
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 5 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -56,5 +56,6 @@ Released with 1.0.0-beta.37 code base.
 
 ### Fixed
 
+- Fix incorrectly populating chainId param with `net_version` when signing txs (#2378)
 - regeneratorRuntime error fixed (#3058)
 - Fix accessing event.name where event is undefined (#3014)
diff --git a/packages/web3-eth-accounts/src/index.js b/packages/web3-eth-accounts/src/index.js
@@ -69,7 +69,7 @@ var Accounts = function Accounts() {
  var _ethereumCall = [
  new Method({
  name: 'getId',
- call: 'net_version',
+ call: 'eth_chainId',
  params: 0,
  outputFormatter: utils.hexToNumber
  }),

diff --git a/test/eth.accounts.signTransaction.js b/test/eth.accounts.signTransaction.js
@@ -495,7 +495,7 @@ describe("eth", function () {
  provider.injectResult(1);
  provider.injectValidation(function (payload) {
  assert.equal(payload.jsonrpc, '2.0');
- assert.equal(payload.method, 'net_version');
+ assert.equal(payload.method, 'eth_chainId');
  assert.deepEqual(payload.params, []);
  });
 
@@ -522,7 +522,7 @@ describe("eth", function () {
  provider.injectResult(1);
  provider.injectValidation(function (payload) {
  assert.equal(payload.jsonrpc, '2.0');
- assert.equal(payload.method, 'net_version');
+ assert.equal(payload.method, 'eth_chainId');
  assert.deepEqual(payload.params, []);
  });
  provider.injectResult(1);

diff --git a/test/helpers/test.method.js b/test/helpers/test.method.js
@@ -10,10 +10,10 @@ var useLocalWallet = function (test, provider, web3) {
 
  test.useLocalWallet(web3);
 
- provider.injectResult(1);
+ provider.injectResult("0x1");
  provider.injectValidation(function (payload) {
  assert.equal(payload.jsonrpc, '2.0');
- assert.equal(payload.method, 'net_version');
+ assert.equal(payload.method, 'eth_chainId');
  assert.deepEqual(payload.params, []);
  });