Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #200

Merged
merged 61 commits into from
Sep 7, 2024
Merged

Dev #200

merged 61 commits into from
Sep 7, 2024

Conversation

zx80
Copy link
Collaborator

@zx80 zx80 commented Aug 20, 2024

WIP

@cofin
Copy link
Contributor

cofin commented Aug 20, 2024

@zx80, I've not had a chance to clean up some of the current work, so there'd not been a PR for this; to the extent it helps any of the work you are doing now, I have an asnycmy adapter that may be useful. that I've not 100% tested, but works for the use case I had. I'll have the aiodbc and the oracle adapters tested soon as well.

@zx80
Copy link
Collaborator Author

zx80 commented Aug 20, 2024

@zx80, I've not had a chance to clean up some of the current work, so there'd not been a PR for this; to the extent it helps any of the work you are doing now, I have an asnycmy adapter that may be useful. that I've not 100% tested, but works for the use case I had. I'll have the aiodbc and the oracle adapters tested soon as well.

Great! Thanks in advance for this and the future reports!
In passing, if you could also test the PEP249 drivers with MS SQL et Oracle with the default adapters (which rely on paramstyle) that would be very nice!

@zx80
Copy link
Collaborator Author

zx80 commented Aug 20, 2024

@cofin would you consider contributing (some/all) of these adapters to aiosql, maybe?

@cofin
Copy link
Contributor

cofin commented Aug 20, 2024

@cofin would you consider contributing (some/all) of these adapters to aiosql, maybe?

@zx80 I'm totally fine with this. This is basically the process that led to the current DuckDB adapter. I also plan to create a Spanner and BigQuery adapter as time permits (if that would be ok?)

@zx80
Copy link
Collaborator Author

zx80 commented Aug 21, 2024

@cofin would you consider contributing (some/all) of these adapters to aiosql, maybe?

@zx80 I'm totally fine with this. This is basically the process that led to the current DuckDB adapter. I also plan to create a Spanner and BigQuery adapter as time permits (if that would be ok?)

👍 😃

@cofin
Copy link
Contributor

cofin commented Aug 23, 2024

@zx80 I'll wait until you've finished your updates here before making more changes. However, I did propose one change that's really a minor "nit". Feel free to merge or not. Thanks again!

cofin and others added 5 commits August 26, 2024 14:23
The SQL of SQL server and the restrictions of pymssql
needed a lot of changes so that most tests could get through,
despite that the actual aiosql code did not incurred any changes.
@zx80 zx80 merged commit a2762a7 into main Sep 7, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants