Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update asyncpg.py #92

Closed
wants to merge 2 commits into from
Closed

Update asyncpg.py #92

wants to merge 2 commits into from

Conversation

singlecheeze
Copy link
Contributor

#90

@benji-york
Copy link
Contributor

If you're open to another drive-by comment... 😄

It would be great to have a test that fails before this change that passes afterward. That way we can both be sure the bug is really fixed and be sure that it stays fixed.

Thanks for working on this!

@benji-york
Copy link
Contributor

Please see PR #94 for an alternative to this PR.

@singlecheeze
Copy link
Contributor Author

@benji-york your solution is better than mine.

Thank YOU for the collaboration!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@singlecheeze @benji-york