Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify npm test script to allow for longer timeout #95

Closed
wants to merge 1 commit into from

Conversation

greatwillow
Copy link

@greatwillow greatwillow commented Jun 2, 2018

This change fixes the timeout error that was occuring upon testing which was causing tests to fail. For further reference to the chosen solution, see here.

Here are some before and after screenshots.

Before Modification

timeouterror

After Modification

after

This change fixes the timeout error that was occuring upon testing which was causing tests to fail.  For further reference, see: mochajs/mocha#2025
@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.482% when pulling bfa6814 on greatwillow:Fix#94 into 216e331 on nadbm:master.

@nadbm
Copy link
Owner

nadbm commented Jun 2, 2018

there shouldn't be any tests that require that long to complete. This is not a fix

@nadbm nadbm closed this Jun 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants