Skip to content

Commit

Permalink
Change the Execution Information icon apache#3464
Browse files Browse the repository at this point in the history
Add missing widget border to ExecInfo transform
  • Loading branch information
nadment committed Dec 26, 2023
1 parent 90d1b9d commit 28b7fb4
Show file tree
Hide file tree
Showing 12 changed files with 113 additions and 29 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ under the License.

= Execution Information Perspective

Icon: image:icons/location.svg[width="24px"]
Icon: image:icons/execution.svg[width="24px"]


== Description
Expand All @@ -33,7 +33,7 @@ The execution information displayed in this perspective is not collected automat

== Navigation

You can navigate to it by clicking the image:icons/location.svg[width="24px"] icon from the vertical perspective toolbar in the Hop GUI.
You can navigate to it by clicking the image:icons/execution.svg[width="24px"] icon from the vertical perspective toolbar in the Hop GUI.

The Keyboard shortcut to do the same is: `CTRL-Shift-I`.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ Here are the available perspectives:

* image:icons/data_orch.svg[width="24px"] xref:hop-gui/perspective-data-orchestration.adoc[Data Orchestration]

* image:icons/location.svg[width="24px"] xref:hop-gui/perspective-execution-information.adoc[Execution Information]
* image:icons/execution.svg[width="24px"] xref:hop-gui/perspective-execution-information.adoc[Execution Information]

* image:icons/gear.svg[width="24px"] xref:hop-gui/perspective-configuration.adoc[Configuration]

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ public String open() {
fdlOperationType.top = new FormAttachment(lastControl, margin);
fdlOperationType.right = new FormAttachment(middle, 0);
wlOperationType.setLayoutData(fdlOperationType);
wOperationType = new CCombo(shell, SWT.LEFT);
wOperationType = new CCombo(shell, SWT.LEFT | SWT.BORDER);
wOperationType.setToolTipText(
BaseMessages.getString(PKG, "ExecInfoDialog.OperationType.Tooltip"));
PropsUi.setLook(wOperationType);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@

@Transform(
id = "ExecInfo",
image = "ui/images/location.svg",
image = "ui/images/execution.svg",
name = "i18n::ExecInfo.Name",
description = "i18n::ExecInfo.Description",
categoryDescription = "i18n:org.apache.hop.pipeline.transform:BaseTransform.Category.Utility",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5336,7 +5336,7 @@ public List<IGuiContextHandler> getContextHandlers() {
type = GuiActionType.Info,
name = "i18n::HopGuiPipelineGraph.ContextualAction.NavigateToExecutionInfo.Text",
tooltip = "i18n::HopGuiPipelineGraph.ContextualAction.NavigateToExecutionInfo.Tooltip",
image = "ui/images/location.svg",
image = "ui/images/execution.svg",
category = "Basic",
categoryOrder = "1")
public void navigateToExecutionInfo(HopGuiPipelineContext context) {
Expand All @@ -5348,7 +5348,7 @@ public void navigateToExecutionInfo(HopGuiPipelineContext context) {
id = TOOLBAR_ITEM_TO_EXECUTION_INFO,
toolTip = "i18n:org.apache.hop.ui.hopgui:HopGui.Toolbar.ToExecutionInfo",
type = GuiToolbarElementType.BUTTON,
image = "ui/images/location.svg")
image = "ui/images/execution.svg")
public void navigateToExecutionInfo() {
try {
// Is there an active IPipeline?
Expand Down Expand Up @@ -5468,7 +5468,7 @@ public void reload() {
type = GuiActionType.Info,
name = "i18n::HopGuiPipelineGraph.TransformAction.ViewExecutionInfo.Name",
tooltip = "i18n::HopGuiPipelineGraph.TransformAction.ViewExecutionInfo.Tooltip",
image = "ui/images/location.svg",
image = "ui/images/execution.svg",
category = "Basic",
categoryOrder = "1")
public void viewTransformExecutionInfo(HopGuiPipelineTransformContext context) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4075,7 +4075,7 @@ public Thread getWorkflowThread() {
type = GuiActionType.Info,
name = "i18n::HopGuiWorkflowGraph.ContextualAction.NavigateToExecutionInfo.Text",
tooltip = "i18n::HopGuiWorkflowGraph.ContextualAction.NavigateToExecutionInfo.Tooltip",
image = "ui/images/location.svg",
image = "ui/images/execution.svg",
category = "i18n::HopGuiWorkflowGraph.ContextualAction.Category.Basic.Text",
categoryOrder = "1")
public void navigateToExecutionInfo(HopGuiWorkflowContext context) {
Expand All @@ -4087,7 +4087,7 @@ public void navigateToExecutionInfo(HopGuiWorkflowContext context) {
id = TOOLBAR_ITEM_TO_EXECUTION_INFO,
toolTip = "i18n:org.apache.hop.ui.hopgui:HopGui.Toolbar.ToExecutionInfo",
type = GuiToolbarElementType.BUTTON,
image = "ui/images/location.svg")
image = "ui/images/execution.svg")
public void navigateToExecutionInfo() {
try {
// Is there an active IWorkflow?
Expand Down Expand Up @@ -4184,7 +4184,7 @@ public void reload() {
type = GuiActionType.Info,
name = "i18n::HopGuiWorkflowGraph.ActionAction.ViewExecutionInfo.Name",
tooltip = "i18n::HopGuiWorkflowGraph.ActionAction.ViewExecutionInfo.Tooltip",
image = "ui/images/location.svg",
image = "ui/images/execution.svg",
category = "Basic",
categoryOrder = "1")
public void viewActionExecutionInfo(HopGuiWorkflowActionContext context) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@
id = "150-HopExecutionPerspective",
name = "i18n::ExecutionPerspective.Name",
description = "i18n::ExecutionPerspective.Description",
image = "ui/images/location.svg")
image = "ui/images/execution.svg")
@GuiPlugin
public class ExecutionPerspective implements IHopPerspective, TabClosable {

Expand Down
34 changes: 34 additions & 0 deletions ui/src/main/resources/ui/images/execution.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

0 comments on commit 28b7fb4

Please sign in to comment.