Add a red border around the action on failure apache#3701

nadment · Mar 6, 2024 · 52fd36b · 52fd36b
1 parent bc88aa5
commit 52fd36b
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/engine/src/main/java/org/apache/hop/workflow/WorkflowPainter.java b/engine/src/main/java/org/apache/hop/workflow/WorkflowPainter.java
@@ -254,7 +254,13 @@ protected void drawAction(ActionMeta actionMeta) throws HopException {
  areaOwners.add(
  new AreaOwner(AreaType.ACTION_ICON, x, y, iconSize, iconSize, offset, subject, actionMeta));
 
- if (actionMeta.isMissing()) {
+ boolean actionError = false;
+ ActionResult actionResult = findActionResult(actionMeta);
+ if ( actionResult!=null && !actionResult.isCheckpoint() ) { 
+ actionError = !actionResult.getResult().getResult();
+ }
+
+ if (actionError || actionMeta.isMissing()) {
  gc.setForeground(EColor.RED);
  } else if (actionMeta.isDeprecated()) {
  gc.setForeground(EColor.DEPRECATED);
@@ -350,7 +356,6 @@ protected void drawAction(ActionMeta actionMeta) throws HopException {
  actionMeta));
  }
 
- ActionResult actionResult = findActionResult(actionMeta);
  if (actionResult != null) {
  Result result = actionResult.getResult();
  int iconX = (x + iconSize) - (miniIconSize / 2) + 1;