Deprecate ActionBase.getUsedDatabaseConnections method apache#2041

nadment · Jul 25, 2024 · 7eb638d · 7eb638d
1 parent a0ffc25
commit 7eb638d
Show file tree

Hide file tree

Showing 9 changed files with 1 addition and 56 deletions.
diff --git a/engine/src/main/java/org/apache/hop/workflow/action/ActionBase.java b/engine/src/main/java/org/apache/hop/workflow/action/ActionBase.java
@@ -481,6 +481,7 @@ public String getRealFilename() {
    *
    * @return an empty (non-null) array
    */
+  @Deprecated(since = "2.10")
   public DatabaseMeta[] getUsedDatabaseConnections() {
     return new DatabaseMeta[] {};
   }

diff --git a/...main/java/org/apache/hop/workflow/actions/checkdbconnection/ActionCheckDbConnections.java b/...main/java/org/apache/hop/workflow/actions/checkdbconnection/ActionCheckDbConnections.java
@@ -195,17 +195,6 @@ public boolean isEvaluation() {
     return true;
   }
 
-  @Override
-  public DatabaseMeta[] getUsedDatabaseConnections() {
-    List<DatabaseMeta> used = new ArrayList<>();
-    for (CDConnection connection : connections) {
-      if (connection.getDatabaseMeta() != null) {
-        used.add(connection.getDatabaseMeta());
-      }
-    }
-    return used.toArray(new DatabaseMeta[0]);
-  }
-
   @Override
   public List<ResourceReference> getResourceDependencies(
       IVariables variables, WorkflowMeta workflowMeta) {

diff --git a/...sexist/src/main/java/org/apache/hop/workflow/actions/columnsexist/ActionColumnsExist.java b/...sexist/src/main/java/org/apache/hop/workflow/actions/columnsexist/ActionColumnsExist.java
@@ -226,13 +226,6 @@ public Result execute(Result previousResult, int nr) {
     return result;
   }
 
-  @Override
-  public DatabaseMeta[] getUsedDatabaseConnections() {
-    return new DatabaseMeta[] {
-      databaseMeta,
-    };
-  }
-
   @Override
   public List<ResourceReference> getResourceDependencies(
       IVariables variables, WorkflowMeta workflowMeta) {

diff --git a/...ain/java/org/apache/hop/workflow/actions/evaluatetablecontent/ActionEvalTableContent.java b/...ain/java/org/apache/hop/workflow/actions/evaluatetablecontent/ActionEvalTableContent.java
@@ -405,13 +405,6 @@ public Result execute(Result previousResult, int nr) {
     return result;
   }
 
-  @Override
-  public DatabaseMeta[] getUsedDatabaseConnections() {
-    return new DatabaseMeta[] {
-      connection,
-    };
-  }
-
   @Override
   public List<ResourceReference> getResourceDependencies(
       IVariables variables, WorkflowMeta workflowMeta) {

diff --git a/...load/src/main/java/org/apache/hop/workflow/actions/mssqlbulkload/ActionMssqlBulkLoad.java b/...load/src/main/java/org/apache/hop/workflow/actions/mssqlbulkload/ActionMssqlBulkLoad.java
@@ -559,13 +559,6 @@ public Result execute(Result previousResult, int nr) {
     return result;
   }
 
-  @Override
-  public DatabaseMeta[] getUsedDatabaseConnections() {
-    return new DatabaseMeta[] {
-      connection,
-    };
-  }
-
   public void setFilename(String filename) {
     this.filename = filename;
   }

diff --git a/...file/src/main/java/org/apache/hop/workflow/actions/mysqlbulkfile/ActionMysqlBulkFile.java b/...file/src/main/java/org/apache/hop/workflow/actions/mysqlbulkfile/ActionMysqlBulkFile.java
@@ -424,13 +424,6 @@ public Result execute(Result previousResult, int nr) {
     return result;
   }
 
-  @Override
-  public DatabaseMeta[] getUsedDatabaseConnections() {
-    return new DatabaseMeta[] {
-      connection,
-    };
-  }
-
   public void setHighPriority(boolean highpriority) {
     this.highPriority = highpriority;
   }

diff --git a/...load/src/main/java/org/apache/hop/workflow/actions/mysqlbulkload/ActionMysqlBulkLoad.java b/...load/src/main/java/org/apache/hop/workflow/actions/mysqlbulkload/ActionMysqlBulkLoad.java
@@ -431,13 +431,6 @@ public Result execute(Result previousResult, int nr) {
     return result;
   }
 
-  @Override
-  public DatabaseMeta[] getUsedDatabaseConnections() {
-    return new DatabaseMeta[] {
-      connection,
-    };
-  }
-
   public boolean isReplacedata() {
     return replacedata;
   }

diff --git a/plugins/actions/sql/src/main/java/org/apache/hop/workflow/actions/sql/ActionSql.java b/plugins/actions/sql/src/main/java/org/apache/hop/workflow/actions/sql/ActionSql.java
@@ -254,11 +254,6 @@ public boolean isUnconditional() {
     return true;
   }
 
-  @Override
-  public DatabaseMeta[] getUsedDatabaseConnections() {
-    return new DatabaseMeta[0];
-  }
-
   @Override
   public List<ResourceReference> getResourceDependencies(
       IVariables variables, WorkflowMeta workflowMeta) {

diff --git a/...waitforsql/src/main/java/org/apache/hop/workflow/actions/waitforsql/ActionWaitForSql.java b/...waitforsql/src/main/java/org/apache/hop/workflow/actions/waitforsql/ActionWaitForSql.java
@@ -471,11 +471,6 @@ protected boolean sqlDataOK(
     return successOK;
   }
 
-  @Override
-  public DatabaseMeta[] getUsedDatabaseConnections() {
-    return new DatabaseMeta[0];
-  }
-
   @Override
   public List<ResourceReference> getResourceDependencies(
       IVariables variables, WorkflowMeta workflowMeta) {