Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.x] Bugfix: Prevent Class Overrides for the Existing Models #35

Merged
merged 5 commits into from
Mar 15, 2021
Merged

[2.x] Bugfix: Prevent Class Overrides for the Existing Models #35

merged 5 commits into from
Mar 15, 2021

Conversation

nafiesl
Copy link
Owner

@nafiesl nafiesl commented Mar 14, 2021 •
edited
Loading

In this PR, we are preventing class content override when generating CRUD scaffolds for an existing model. Fixes #33

When we run the make:crud command for an existing model and answering yes on the confirmation question:

  • Prevent override model content
  • Prevent override model factory content
  • Prevent override model policy content
  • Add console warn for the existing class files

@nafiesl nafiesl mentioned this pull request Mar 14, 2021
Closed
@nafiesl nafiesl marked this pull request as ready for review March 15, 2021 14:36
@nafiesl nafiesl merged commit 1d505bf into master Mar 15, 2021
@nafiesl nafiesl deleted the 33_bug_model_overrides branch March 15, 2021 14:36
@nafiesl nafiesl changed the title Bugfix: Prevent Class Overrides for the Existing Models [2.x] Bugfix: Prevent Class Overrides for the Existing Models Mar 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't override model
1 participant
@nafiesl