Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #932 Fixed #1

Merged
merged 32 commits into from
Jan 1, 2024
Merged

Issue #932 Fixed #1

merged 32 commits into from
Jan 1, 2024

Commits on Dec 26, 2023

  1. Configuration menu
    Copy the full SHA
    dec964e View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    45d2ba7 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    e192989 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6aad653 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    c2d906e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    932de66 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    116aaa9 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    ba90e0e View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    ac9b791 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    3804859 View commit details
    Browse the repository at this point in the history
  11. Drop an unneeded variable

    imobachgs committed Dec 26, 2023
    Configuration menu
    Copy the full SHA
    16cada3 View commit details
    Browse the repository at this point in the history

Commits on Dec 27, 2023

  1. Configuration menu
    Copy the full SHA
    be094a5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    615d4a1 View commit details
    Browse the repository at this point in the history
  3. Documentation fixes

    Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.de>
    imobachgs and teclator authored Dec 27, 2023
    Configuration menu
    Copy the full SHA
    3eb41cd View commit details
    Browse the repository at this point in the history
  4. Improve D-Bus network interface (#961)

    ## Problem
    
    Until now, the communication between our network model and its D-Bus
    interface worked only in one direction (from D-Bus to the model). And
    that was pretty limiting.
    
    ## Solution
    
    In #885 we introduce the usage of `oneshot::channel()` to enable
    bi-directional communication between the model and the D-Bus interface.
    It worked rather well, so it is time to extend this approach.
    
    Some use cases that are covered:
    
    * Perform a complex validation in the model (considering the whole
    model) and return the result to the D-Bus interface.
    * Return the D-Bus path of a new connection (implemented in this PR).
    
    But there is another interesting implication: the model is the single
    source of truth (no more cloned data in the interface). In the future,
    we are expected to listen to NetworkManager and update some parts of our
    model accordingly. Not having to replicate that information to D-Bus
    (except when new things add or disappear) makes things easier.
    
    Note: `org.opensuse.Agama1.Network.Device` and
    `org.opensuse.Agama1.Network.Devices` are excluded by now.
    
    ## Testing
    
    - *Added a new unit test*
    - *Tested manually*
    
    
    ## To do
    
    - [x] Reduce the boilerplate associated to the usage of channels.
    imobachgs authored Dec 27, 2023
    Configuration menu
    Copy the full SHA
    3deeadc View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7b00e7e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    4a76c9e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c7d43c8 View commit details
    Browse the repository at this point in the history
  8. Run Clippy in CI

    imobachgs committed Dec 27, 2023
    Configuration menu
    Copy the full SHA
    d5860fa View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2023

  1. Update service PO files

    Agama-weblate commit: 2ad365d9d13ef872b40b5aa4fb5bd4e99f104def
    yast-bot committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    9bbf3a4 View commit details
    Browse the repository at this point in the history
  2. Update service PO files (#963)

    Updating the service translation files from the agama-weblate repository
    imobachgs authored Dec 28, 2023
    Configuration menu
    Copy the full SHA
    334f7d0 View commit details
    Browse the repository at this point in the history
  3. Adapt the code to Clippy suggestions (#962)

    - Fix several issues detected by Clippy.
    - Rename agama-dbus-server "locale" to "l10n" (to avoid
    `locale/locale`).
    - Define some 'types' for D-Bus proxies to make easier to read the code.
    - Run Clippy in the continuous integration.
    imobachgs authored Dec 28, 2023
    Configuration menu
    Copy the full SHA
    c8bb1fe View commit details
    Browse the repository at this point in the history
  4. Update service PO files

    Agama-weblate commit: d0322d40d617c6790d5a2767fd47ca98ff25f3e0
    yast-bot committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    bc6ef3a View commit details
    Browse the repository at this point in the history
  5. Update service PO files (#964)

    Updating the service translation files from the agama-weblate repository
    imobachgs authored Dec 28, 2023
    Configuration menu
    Copy the full SHA
    51abf8d View commit details
    Browse the repository at this point in the history

Commits on Dec 29, 2023

  1. Configuration menu
    Copy the full SHA
    96036d4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d83b01e View commit details
    Browse the repository at this point in the history
  3. Set minimal Rust version to 1.74

    * It prevents a "future cannot be sent between threads safely" error.
    imobachgs committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    7d84f6d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f652948 View commit details
    Browse the repository at this point in the history
  5. Drop objects registry mutex (#965)

    * Drop the ObjectsRegistry mutex and use message passing.
    * Use `async_trait` in the network Adapter trait, although it should not
    be needed in version 1.75 (another PR would follow).
    * Set the minimal version to 1.74.
    * Improve ServiceError messages.
    imobachgs authored Dec 29, 2023
    Configuration menu
    Copy the full SHA
    e4ae7ed View commit details
    Browse the repository at this point in the history
  6. Avoid a deadlock updating the network D-Bus tree

    Updating the tree must be done in a separate task. Otherwise, it could
    fight with an incoming request for the ObjectServer mutex, blocking the
    actions dispatching.
    imobachgs committed Dec 29, 2023
    Configuration menu
    Copy the full SHA
    1c9ec66 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    c40e251 View commit details
    Browse the repository at this point in the history
  8. Avoid a deadlock updating the network D-Bus tree (#966)

    ## Problem
    
    If the network service receives an `Apply` at the same time as any other
    request, it may get blocked.
    
    ## Solution
    
    Updating the tree must be done in a separate task. Otherwise, it could
    fight with an incoming request for the ObjectServer mutex, blocking the
    actions dispatching.
    
    ## Using tokio-console
    
    I decided to use
    [tokio-console](https://docs.rs/tokio-console/latest/tokio_console/) to
    make it easier to find the problem. This tool collects and displays
    information about the asynchronous tasks in your program. In the
    screenshot below you can see that the D-Bus `Set` dispatchers are
    blocked.
    
    ![Captura desde 2023-12-29
    10-52-45](https://github.com/openSUSE/agama/assets/15836/648e5f1e-eb6b-431b-be40-45cdeaf9e980)
    
    Once you find the problem, it is kind of "obvious", but it may take some
    time until you figure out what is happening.
    
    To use `tokio-console` you need to add some instrumentation to your
    program and, at this point, it implies adding some unstable Tokio APIs.
    So if you want to give it a try, you can try the code in the
    [tokio-console
    branch](https://github.com/openSUSE/agama/compare/tokio-console).
    imobachgs authored Dec 29, 2023
    Configuration menu
    Copy the full SHA
    d9b0131 View commit details
    Browse the repository at this point in the history