-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #932 Fixed #1
Commits on Dec 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for dec964e - Browse repository at this point
Copy the full SHA dec964eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45d2ba7 - Browse repository at this point
Copy the full SHA 45d2ba7View commit details -
Configuration menu - View commit details
-
Copy full SHA for e192989 - Browse repository at this point
Copy the full SHA e192989View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6aad653 - Browse repository at this point
Copy the full SHA 6aad653View commit details -
Configuration menu - View commit details
-
Copy full SHA for c2d906e - Browse repository at this point
Copy the full SHA c2d906eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 932de66 - Browse repository at this point
Copy the full SHA 932de66View commit details -
Configuration menu - View commit details
-
Copy full SHA for 116aaa9 - Browse repository at this point
Copy the full SHA 116aaa9View commit details -
Configuration menu - View commit details
-
Copy full SHA for ba90e0e - Browse repository at this point
Copy the full SHA ba90e0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ac9b791 - Browse repository at this point
Copy the full SHA ac9b791View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3804859 - Browse repository at this point
Copy the full SHA 3804859View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16cada3 - Browse repository at this point
Copy the full SHA 16cada3View commit details
Commits on Dec 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for be094a5 - Browse repository at this point
Copy the full SHA be094a5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 615d4a1 - Browse repository at this point
Copy the full SHA 615d4a1View commit details -
Co-authored-by: Knut Alejandro Anderssen González <kanderssen@suse.de>
Configuration menu - View commit details
-
Copy full SHA for 3eb41cd - Browse repository at this point
Copy the full SHA 3eb41cdView commit details -
Improve D-Bus network interface (#961)
## Problem Until now, the communication between our network model and its D-Bus interface worked only in one direction (from D-Bus to the model). And that was pretty limiting. ## Solution In #885 we introduce the usage of `oneshot::channel()` to enable bi-directional communication between the model and the D-Bus interface. It worked rather well, so it is time to extend this approach. Some use cases that are covered: * Perform a complex validation in the model (considering the whole model) and return the result to the D-Bus interface. * Return the D-Bus path of a new connection (implemented in this PR). But there is another interesting implication: the model is the single source of truth (no more cloned data in the interface). In the future, we are expected to listen to NetworkManager and update some parts of our model accordingly. Not having to replicate that information to D-Bus (except when new things add or disappear) makes things easier. Note: `org.opensuse.Agama1.Network.Device` and `org.opensuse.Agama1.Network.Devices` are excluded by now. ## Testing - *Added a new unit test* - *Tested manually* ## To do - [x] Reduce the boilerplate associated to the usage of channels.
Configuration menu - View commit details
-
Copy full SHA for 3deeadc - Browse repository at this point
Copy the full SHA 3deeadcView commit details -
Configuration menu - View commit details
-
Copy full SHA for 7b00e7e - Browse repository at this point
Copy the full SHA 7b00e7eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4a76c9e - Browse repository at this point
Copy the full SHA 4a76c9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for c7d43c8 - Browse repository at this point
Copy the full SHA c7d43c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for d5860fa - Browse repository at this point
Copy the full SHA d5860faView commit details
Commits on Dec 28, 2023
-
Agama-weblate commit: 2ad365d9d13ef872b40b5aa4fb5bd4e99f104def
Configuration menu - View commit details
-
Copy full SHA for 9bbf3a4 - Browse repository at this point
Copy the full SHA 9bbf3a4View commit details -
Update service PO files (#963)
Updating the service translation files from the agama-weblate repository
Configuration menu - View commit details
-
Copy full SHA for 334f7d0 - Browse repository at this point
Copy the full SHA 334f7d0View commit details -
Adapt the code to Clippy suggestions (#962)
- Fix several issues detected by Clippy. - Rename agama-dbus-server "locale" to "l10n" (to avoid `locale/locale`). - Define some 'types' for D-Bus proxies to make easier to read the code. - Run Clippy in the continuous integration.
Configuration menu - View commit details
-
Copy full SHA for c8bb1fe - Browse repository at this point
Copy the full SHA c8bb1feView commit details -
Agama-weblate commit: d0322d40d617c6790d5a2767fd47ca98ff25f3e0
Configuration menu - View commit details
-
Copy full SHA for bc6ef3a - Browse repository at this point
Copy the full SHA bc6ef3aView commit details -
Update service PO files (#964)
Updating the service translation files from the agama-weblate repository
Configuration menu - View commit details
-
Copy full SHA for 51abf8d - Browse repository at this point
Copy the full SHA 51abf8dView commit details
Commits on Dec 29, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 96036d4 - Browse repository at this point
Copy the full SHA 96036d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for d83b01e - Browse repository at this point
Copy the full SHA d83b01eView commit details -
Set minimal Rust version to 1.74
* It prevents a "future cannot be sent between threads safely" error.
Configuration menu - View commit details
-
Copy full SHA for 7d84f6d - Browse repository at this point
Copy the full SHA 7d84f6dView commit details -
Configuration menu - View commit details
-
Copy full SHA for f652948 - Browse repository at this point
Copy the full SHA f652948View commit details -
Drop objects registry mutex (#965)
* Drop the ObjectsRegistry mutex and use message passing. * Use `async_trait` in the network Adapter trait, although it should not be needed in version 1.75 (another PR would follow). * Set the minimal version to 1.74. * Improve ServiceError messages.
Configuration menu - View commit details
-
Copy full SHA for e4ae7ed - Browse repository at this point
Copy the full SHA e4ae7edView commit details -
Avoid a deadlock updating the network D-Bus tree
Updating the tree must be done in a separate task. Otherwise, it could fight with an incoming request for the ObjectServer mutex, blocking the actions dispatching.
Configuration menu - View commit details
-
Copy full SHA for 1c9ec66 - Browse repository at this point
Copy the full SHA 1c9ec66View commit details -
Configuration menu - View commit details
-
Copy full SHA for c40e251 - Browse repository at this point
Copy the full SHA c40e251View commit details -
Avoid a deadlock updating the network D-Bus tree (#966)
## Problem If the network service receives an `Apply` at the same time as any other request, it may get blocked. ## Solution Updating the tree must be done in a separate task. Otherwise, it could fight with an incoming request for the ObjectServer mutex, blocking the actions dispatching. ## Using tokio-console I decided to use [tokio-console](https://docs.rs/tokio-console/latest/tokio_console/) to make it easier to find the problem. This tool collects and displays information about the asynchronous tasks in your program. In the screenshot below you can see that the D-Bus `Set` dispatchers are blocked. ![Captura desde 2023-12-29 10-52-45](https://github.com/openSUSE/agama/assets/15836/648e5f1e-eb6b-431b-be40-45cdeaf9e980) Once you find the problem, it is kind of "obvious", but it may take some time until you figure out what is happening. To use `tokio-console` you need to add some instrumentation to your program and, at this point, it implies adding some unstable Tokio APIs. So if you want to give it a try, you can try the code in the [tokio-console branch](https://github.com/openSUSE/agama/compare/tokio-console).
Configuration menu - View commit details
-
Copy full SHA for d9b0131 - Browse repository at this point
Copy the full SHA d9b0131View commit details