Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add progress listeners to the long running operations #297

Closed
12 tasks done
nagyesta opened this issue Aug 3, 2024 · 0 comments
Closed
12 tasks done

Add progress listeners to the long running operations #297

nagyesta opened this issue Aug 3, 2024 · 0 comments
Assignees
@nagyesta
Labels
enhancement New feature or request

Comments

@nagyesta
Copy link
Owner

nagyesta commented Aug 3, 2024 •
edited
Loading

Done criteria

  • Reusable progress listener class is implemented
  • Progress listener is integrated into
    • Backup
    • Restore
    • Merge
    • Inspect increments
    • Inspect increment contents operations
  • Change API to avoid similar breaking changes (caused by new optional parameters) in the future
    • API changes done in prod code
    • API changes done in tests
    • Documentation updated
  • New functionality is covered with tests

Notes

  • Use high-level steps for each long running operation
  • When possible give precise progress within the steps
  • Avoid large jumps in progress when possible (for example during backup, avoid file count based estimate and favor data size based progress to avoid causing uneven progress when the file sizes are not perfectly unified)
@nagyesta nagyesta converted this from a draft issue Aug 3, 2024
@nagyesta nagyesta added the enhancement New feature or request label Aug 3, 2024
@nagyesta nagyesta self-assigned this Aug 3, 2024
@nagyesta nagyesta moved this from Prioritized backlog to In progress in File BaRJ Roadmap Aug 3, 2024
nagyesta added a commit that referenced this issue Aug 19, 2024
@nagyesta
Add progress listeners to the long-running operations
a4e3734 
- Defines progress tracker and listener interface
- Implements progress tracker
- Implements logging progress listener
- Integrates progress tracking into backup operations
- Adds new tests
- Fixes the order of modifiers for the whole codebase

Updates #297
{minor}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
nagyesta added a commit that referenced this issue Aug 20, 2024
@nagyesta
Add progress listeners to the long-running operations
d1e91a5 
- Defines progress tracker and listener interface
- Implements progress tracker
- Implements logging progress listener
- Fixes log patterns to make logs easier to read
- Integrates progress tracking into backup, restore, merge, inspect operations
- Adds new tests
- Fixes the order of modifiers for the whole codebase
- Fixes an issue causing incorrect backup type to be reported in case of forced full backups

Updates #297
{minor}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
nagyesta added a commit that referenced this issue Aug 21, 2024
@nagyesta
Add progress listeners to the long-running operations
8d16b33 
- Modified progress tracking to make it more flexible
- Changed approach for passing input parameters to controllers
- Defined new parameter VOs with builders

Updates #297
{minor}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
nagyesta added a commit that referenced this issue Aug 23, 2024
@nagyesta
Add progress listeners to the long-running operations
34c5ad4 
- Defines progress tracker and listener interface
- Implements progress tracker
- Implements logging progress listener
- Fixes log patterns to make logs easier to read
- Integrates progress tracking into backup, restore, merge, inspect operations
- Adds new tests
- Fixes the order of modifiers for the whole codebase
- Fixes an issue causing incorrect backup type to be reported in case of forced full backups
- Changes approach for passing input parameters to controllers
- Defines new parameter VOs with builders
- Updates tests and documentation

Resolves #297
{major}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
@nagyesta nagyesta mentioned this issue Aug 23, 2024
Merged
5 tasks
nagyesta added a commit that referenced this issue Aug 23, 2024
@nagyesta
Add progress listeners to the long-running operations
3b6fac7 
- Defines progress tracker and listener interface
- Implements progress tracker
- Implements logging progress listener
- Fixes log patterns to make logs easier to read
- Integrates progress tracking into backup, restore, merge, inspect operations
- Adds new tests
- Fixes the order of modifiers for the whole codebase
- Fixes an issue causing incorrect backup type to be reported in case of forced full backups
- Changes approach for passing input parameters to controllers
- Defines new parameter VOs with builders
- Updates tests and documentation

Resolves #297
{major}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
nagyesta added a commit that referenced this issue Aug 23, 2024
@nagyesta
Add progress listeners to the long-running operations
bf9bff5 
- Defines progress tracker and listener interface
- Implements progress tracker
- Implements logging progress listener
- Fixes log patterns to make logs easier to read
- Integrates progress tracking into backup, restore, merge, inspect operations
- Adds new tests
- Fixes the order of modifiers for the whole codebase
- Fixes an issue causing incorrect backup type to be reported in case of forced full backups
- Changes approach for passing input parameters to controllers
- Defines new parameter VOs with builders
- Updates tests and documentation

Resolves #297
{major}

Signed-off-by: Esta Nagy <nagyesta@gmail.com>
@github-project-automation github-project-automation bot moved this from In progress to Released in File BaRJ Roadmap Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nagyesta nagyesta

Labels
enhancement New feature or request
Projects
File BaRJ Roadmap
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nagyesta