Add support for OpenSearch #113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Creating a trait that all Aiven objects can implement to enable applying mutators across all future Aiven types.
…c types All relevant objects have data in the same fields, and the DynamicObject allows generic access to those fields. It makes much more sense to implement mutations on the basis of the generic access in DynamicObject, than implementing the AivenObject trait for all Aiven types with identical code for each type.
By using only DynamicObject, our code is much simpler and more generic. This also avoids the need to be dependent on generated types from Aiven-operator repo.
mortenlj
force-pushed
the
open_search
branch
from
3847aa0 to
ef99ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some details that need to be checked, and some code that looks like it could be improved with some expert eyes.
Fixes #96