Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

moves uint64 on struct top #109

Merged
merged 1 commit into from
Aug 17, 2021
Merged

Conversation

xsteadfastx
Copy link
Contributor

i added ali as apk package for alpine linux. we discovered that it failed on 32 bit arches. this is a try to fix this.

@xsteadfastx
Copy link
Contributor Author

here are the logs from the build servers: https://gitlab.alpinelinux.org/alpine/aports/-/jobs/463920

@nakabonne
Copy link
Owner

Hi, does the fixed-length type have to be on the top of struct fields? I didn't even know that but it's a tiny change, let's merge it.

@codecov-commenter
Copy link

codecov-commenter commented Aug 17, 2021

Codecov Report

Merging #109 (f770180) into master (910942e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #109   +/-   ##
=======================================
  Coverage   62.30%   62.30%           
=======================================
  Files          11       11           
  Lines         716      716           
=======================================
  Hits          446      446           
  Misses        235      235           
  Partials       35       35           
Impacted Files Coverage Δ
attacker/resolver.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 910942e...f770180. Read the comment docs.

@nakabonne nakabonne merged commit 422a522 into nakabonne:master Aug 17, 2021
@xsteadfastx
Copy link
Contributor Author

xsteadfastx commented Aug 17, 2021 via email

@nakabonne
Copy link
Owner

That makes sense. I learned something new, thank you!

@xsteadfastx
Copy link
Contributor Author

xsteadfastx commented Aug 17, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants