Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix go test error 'redundant newline' #37

Merged
merged 1 commit into from
Oct 2, 2020
Merged

fix go test error 'redundant newline' #37

merged 1 commit into from
Oct 2, 2020

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Oct 2, 2020

fix #36

@codecov-commenter
Copy link

codecov-commenter commented Oct 2, 2020

Codecov Report

Merging #37 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #37   +/-   ##
=======================================
  Coverage   77.59%   77.59%           
=======================================
  Files           7        7           
  Lines         281      281           
=======================================
  Hits          218      218           
  Misses         45       45           
  Partials       18       18           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96fb6a1...8bbd694. Read the comment docs.

@nakabonne
Copy link
Owner

@ilmanzo Hi, thanks for your contribution! I haven't noticed that since I'm temporarily excluding the main package from being the test scope.

Helped a lot.

@nakabonne nakabonne merged commit 240f393 into nakabonne:master Oct 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

go test fails
3 participants