Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fulfill linter suggestion #42

Merged
merged 1 commit into from
Oct 4, 2020
Merged

fulfill linter suggestion #42

merged 1 commit into from
Oct 4, 2020

Conversation

ilmanzo
Copy link
Contributor

@ilmanzo ilmanzo commented Oct 3, 2020

I think it's also more readable in this way

@codecov-commenter
Copy link

codecov-commenter commented Oct 3, 2020

Codecov Report

Merging #42 into master will decrease coverage by 5.39%.
The diff coverage is 66.67%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #42      +/-   ##
==========================================
- Coverage   77.59%   72.20%   -5.38%     
==========================================
  Files           7        8       +1     
  Lines         281      356      +75     
==========================================
+ Hits          218      257      +39     
- Misses         45       81      +36     
  Partials       18       18              
Impacted Files Coverage Δ
main.go 56.18% <66.67%> (ø)
gui/keybinds.go 40.00% <0.00%> (-1.17%) ⬇️
gui/gui.go 72.92% <0.00%> (-1.08%) ⬇️
gui/drawer.go 92.11% <0.00%> (-0.57%) ⬇️
gui/widgets.go 62.07% <0.00%> (+0.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96fb6a1...bf8c321. Read the comment docs.

@nakabonne
Copy link
Owner

@ilmanzo You're right, nice catch!

@nakabonne nakabonne merged commit 9ad170f into nakabonne:master Oct 4, 2020
@ilmanzo ilmanzo deleted the linter_fix branch October 4, 2020 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants