Add bucket histogram option #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 76.50% 74.59% -1.91%
==========================================
Files 8 8
Lines 400 417 +17
==========================================
+ Hits 306 311 +5
- Misses 75 85 +10
- Partials 19 21 +2
Continue to review full report at Codecov.
|
|
@rzkmak Hey, thank you for your contribution! I can’t afford to check it, so I'll get back to you later :-) |
nakabonne
requested changes
Oct 17, 2020
main.go
Outdated
| @@ -81,6 +83,7 @@ func parseFlags(stdout, stderr io.Writer) (*cli, error) { | |||
| flagSet.IntVarP(&c.connections, "connections", "c", attacker.DefaultConnections, "Amount of maximum open idle connections per target host") | |||
| flagSet.BoolVar(&c.noHTTP2, "no-http2", false, "Don't issue HTTP/2 requests to servers which support it.") | |||
| flagSet.StringVar(&c.localAddress, "local-addr", "0.0.0.0", "Local IP address.") | |||
| flagSet.StringVar(&c.buckets, "buckets", "", "Histogram buckets.") | |||
There was a problem hiding this comment.
Suggested change
| flagSet.StringVar(&c.buckets, "buckets", "", "Histogram buckets.") | |
| flagSet.StringVar(&c.buckets, "buckets", "", "Histogram buckets; comma-separated list.") |
main.go
Outdated
| trimmedBucket := strings.TrimSpace(bucket) | ||
| d, err := time.ParseDuration(trimmedBucket) | ||
| if err != nil { | ||
| log.Fatalf("Invalid bucket time format") |
There was a problem hiding this comment.
Can you make it give back an error if even one of them fails?
main.go
Outdated
Comment on lines
214
to
216
| result := make([]time.Duration, 0) | ||
|
|
||
| stringBuckets := strings.Split(rawBuckets, ",") |
There was a problem hiding this comment.
Suggested change
| result := make([]time.Duration, 0) | |
| stringBuckets := strings.Split(rawBuckets, ",") | |
| stringBuckets := strings.Split(rawBuckets, ",") | |
| result := make([]time.Duration, len(stringBuckets)) | |
|
thank you for the review 👍 |
nakabonne
approved these changes
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to add an option for bucket histogram as in the #63 issue
But I'm not sure where I can put this part
Any feedback or suggestion would help me so much.
Thank you