Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Progress gauge to reach 100% #86

Merged
merged 2 commits into from
Nov 22, 2020

Conversation

shubham14bajpai
Copy link
Contributor

@shubham14bajpai shubham14bajpai commented Nov 16, 2020

Signed-off-by: shubham shubham.bajpai@mayadata.io

This PR fixes the stuck progress bar when the rate flag is more than the system capabilities.
image

The most accurate representation was on nanoseconds so time.Duration.

Signed-off-by: shubham <shubham.bajpai@mayadata.io>
gui/drawer.go Show resolved Hide resolved
gui/drawer.go Outdated Show resolved Hide resolved
gui/drawer.go Outdated Show resolved Hide resolved
@nakabonne
Copy link
Owner

@shubham14bajpai Thank you for your contribution! I've left some comments.

sometimes the progress bar finishes milliseconds before the other sections of the GUI #80 (comment)

This is caused by entirely another problem with ali's drawing performance. If the ali is running at a high rate, the drawing may not be finished after the specified duration of time. This has been improved considerably, but there is still room for improvement.

@shubham14bajpai
Copy link
Contributor Author

@nakabonne I have addressed review comments. PTAL.

Copy link
Owner

@nakabonne nakabonne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty neat. Thanks for your help!

@nakabonne nakabonne merged commit 04b67c9 into nakabonne:master Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants