Fixed interface not opening on Hyprland

[FrancisTheCat]

I am not 100% sure what the parameters that were passed to XCreateWindow before were supposed to do, however I found that switching to XCreateSimpleWindow resolved the problem for me. I also tested the fix on DWM, Openbox and Sway, where it continued working. I might have created some obscure regression by removing the extended parameters, but this seems to be working well. However the person that wrote the original code may have a good reason for choosing XCreateWindow that Im not aware of.

I tested on Arch with recent versions of all the mentioned compositors with an RTX 2060

[FrancisTheCat]

I just noticed this change causes problems with popups :( Ill keep trying to get this to work tho since I really like this debugger

[FrancisTheCat]

I think Ive fixed my fix, tho as a Wayland enjoyer my understanding of X11 does not suffice to explain why it works.

[greg7mdp]

maybe: attributes.override_redirect = True;

[greg7mdp]

I'm wondering if the difference is that you're setting the border_pixel and background_pixel to 0 with XCreateSimpleWindow.

I'd be curious to know if the following works as well (I can't try since unfortunately I can't install hyprland right now):

	XSetWindowAttributes attributes = {};
	attributes.override_redirect = flags & UI_WINDOW_MENU;
        attributes.border_pixel = 0;
        attributes.background_pixel = 0;

	window->window = XCreateWindow(ui.display, DefaultRootWindow(ui.display), 0, 0, width, height, 0, 0,
		InputOutput, CopyFromParent, CWOverrideRedirect | CWBorderPixel | CWBackPixel, &attributes);

[FrancisTheCat]

I'm wondering if the difference is that you're setting the border_pixel and background_pixel to 0 with XCreateSimpleWindow.

I'd be curious to know if the following works as well (I can't try since unfortunately I can't install hyprland right now):

	XSetWindowAttributes attributes = {};
	attributes.override_redirect = flags & UI_WINDOW_MENU;
        attributes.border_pixel = 0;
        attributes.background_pixel = 0;

	window->window = XCreateWindow(ui.display, DefaultRootWindow(ui.display), 0, 0, width, height, 0, 0,
		InputOutput, CopyFromParent, CWOverrideRedirect | CWBorderPixel | CWBackPixel, &attributes);

doesn't help :(

[greg7mdp]

doesn't help :(

Weird. It's gotta be the InputOutput then. Maybe it should be CopyFromParent instead?

[FrancisTheCat]

doesn't help :(

Weird. It's gotta be the InputOutput then. Maybe it should be CopyFromParent instead?

didnt help either, I think we should just write this off as a weird xwayland bug

[greg7mdp]

didnt help either

Well thanks for checking anyways!