feat: refactor client for parallel usage #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To make sure that concurrent calls for get and request can be made, it is easier to move some of the logic from the class level to the function level. For example, this will ensure that the data retrieved after a request is always associated to this specific request Signed-off-by: polnico <pol.nicolai@gmail.com>
Signed-off-by: polnico <pol.nicolai@gmail.com>
The status code value is not part any longer of the request object, which means it should not be checked after in tests. However we can still check content pf response + other errors. Finally some helper functions were removed, so the associated tests were also removed. Signed-off-by: polnico <pol.nicolai@gmail.com>
Signed-off-by: polnico <pol.nicolai@gmail.com>
Instead of creating a new one for each request, reuse the existing one. This also works for //ism as the requests lib already uses connection pooling Signed-off-by: polnico <pol.nicolai@gmail.com>
deperonnier
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To make sure that concurrent calls for get and request can be made, it is easier to move some of the logic from the class level to the function level.
For example, this will ensure that the data retrieved after a request is always associated to this specific request